Skip to content

Visualization Layer: Data Parsing Service #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 21, 2024
Merged

Visualization Layer: Data Parsing Service #176

merged 17 commits into from
Aug 21, 2024

Conversation

kunkunzhu
Copy link
Contributor

@kunkunzhu kunkunzhu commented Aug 13, 2024 •
edited
Loading

Changelogs

  • Add content type field to Column Annotation object

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the newly introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix, chore, documentation or test (or ask a maintainer to do it for you).

discussion related to that PR

Issue #422

@kunkunzhu kunkunzhu self-assigned this Aug 13, 2024
@kunkunzhu kunkunzhu requested a review from cwognum as a code owner August 13, 2024 19:42
@kunkunzhu kunkunzhu marked this pull request as draft August 13, 2024 19:42
@kunkunzhu kunkunzhu added the feature Annotates any PR that adds new features; Used in the release process label Aug 13, 2024
@kunkunzhu kunkunzhu marked this pull request as ready for review August 19, 2024 17:08
@kunkunzhu kunkunzhu requested a review from jstlaurent August 19, 2024 17:08
jstlaurent
jstlaurent reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@jstlaurent jstlaurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. 😄

cwognum
cwognum approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@cwognum cwognum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like that we're using the term content type and known MIME types. We're not reinventing the wheel here!

@kunkunzhu kunkunzhu merged commit 578443e into main Aug 21, 2024
4 checks passed
@kunkunzhu kunkunzhu deleted the viz-layer/data-parsing branch August 21, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstlaurent jstlaurent jstlaurent left review comments

@cwognum cwognum cwognum approved these changes

Assignees

@kunkunzhu kunkunzhu

Labels
feature Annotates any PR that adds new features; Used in the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunkunzhu @jstlaurent @cwognum