Remove pov-reclaim from kusama system-chains#423
Merged
fellowship-merge-bot[bot] merged 6 commits intoAug 13, 2024
Merged
Conversation
s0me0ne-unkn0wn
approved these changes
Aug 8, 2024
s0me0ne-unkn0wn
left a comment
s0me0ne-unkn0wn
left a comment
Contributor
There was a problem hiding this comment.
We're currently nowhere near the situation where we could benefit from having the PoV reclaim on system chains, so it makes sense to remove it for now just to be on the safe side.
bkchr
approved these changes
Aug 12, 2024
Contributor
|
/merge |
Contributor
|
Enabled Available commands
For more information see the documentation |
sandreim
approved these changes
Aug 12, 2024
acatangiu
approved these changes
Aug 12, 2024
Contributor
Failed to update PR ❌There was an error while trying to keep this PR You may have conflicts More info in the logs 📋 |
ggwpez
approved these changes
Aug 13, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to move PoV-reclaim to the next release.
It can happen that the amount to reclaim is overestimated paritytech/polkadot-sdk#5229.
Improvements (paritytech/polkadot-sdk#5281, paritytech/polkadot-sdk#5273) and a proper fix (paritytech/polkadot-sdk#5234) are in the works, but should be tested again.
I expect the chances that the system-chains run into this scenario to be low, but it does not look like activity is so high that the inclusion of reclaim is urgent.