upgrade to v1.2 by muharem · Pull Request #56 · polkadot-fellows/runtimes

muharem · 2023-10-04T10:47:15Z

In the PR we bump versions for all dependacy crates from polkadot-sdk and apply all required changes

Changes:

parachains_runtime_api_impl v5 -> v7,
- from Migrate polkadot-primitives to v6 paritytech/polkadot-sdk#1543;
Consideration setup for preimage pallet instances,
- from FRAME: Revamp Preimage pallet to use Consideration paritytech/polkadot-sdk#1363;
experimental feature removed for pallet-society, pallet-xcm, runtime-common crates,
- from Stabilize VersionedMigration paritytech/polkadot-sdk#1503;
pallet_election_provider_multi_phase::Config::SignedDepositBase set to GeometricDepositBase,
- from Implements a variable deposit base calculation for EPM signed submissions paritytech/polkadot-sdk#1547;
support open_outbound_hrmp_channel_for_benchmarks_or_tests func rename,
- from Added xcmp_queue_send_xcm_works test paritytech/polkadot-sdk#1422;
missing weight functions added for runtime_parachains_hrmp and pallet_preimage;

TODO:

Deleted the Copy&paste para scheduler migration from Update Polkadot ideal staking rate #26 in b666613. This should be applied in the next runtime upgrade, but i did not properly check yet.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

bkchr · 2023-11-06T14:34:04Z

 		pallet_im_online::migration::v1::Migration<Runtime>,
 		parachains_configuration::migration::v7::MigrateToV7<Runtime>,
-		crate::paras_scheduler_migration::v1::MigrateToV1<Runtime>,
+		//crate::paras_scheduler_migration::v1::MigrateToV1<Runtime>, // TODO


We should be able to remove all of the migrations. Or we keep them here longer until the next release.

I would remove migrations only after we see them enacted on-chain - just because we released them is no guarantee they will also run (maybe that runtime release gets skipped on-chain)..

Yeah for the CI we need to keep them any way.

We can re-add that migration, but it but it is a slightly different version from the SDK. The version that was commented here was a copy&paste version that does not compile anymore.

Ahh it doesn't compile. Yeah then let's remove it. I think my fixed version should be in 1.3.0

acatangiu · 2023-11-09T08:48:05Z

@muharem is this PR ready? I am confused by TODO in description..

ggwpez · 2023-11-09T11:41:55Z

@muharem is this PR ready? I am confused by TODO in description..

Sorry i added it.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

This reverts commit 8f614ae.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Co-authored-by: Bastian Köcher <git@kchr.de>

paritytech-review-bot · 2023-11-20T16:26:16Z

There was a problem running the action.

❌😵❌

Please find more information in the logs.

bkchr · 2023-11-20T16:26:55Z

We are missing an entry to CHANGELOG.md 🙈

muharem · 2023-11-20T18:23:05Z

We are missing an entry to CHANGELOG.md 🙈

added, please review. feel free to commit the suggestions.

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

bkchr · 2023-11-20T19:37:35Z

+- Upgrade parachains runtime API from v5 to v7 in Polkadot and Kusama ([polkadot-fellows/runtimes#56](https://github.com/polkadot-fellows/runtimes/pull/56))
+- Upgrade Preimage pallet's config implementations to adapt the new `Consideration` API ([polkadot-fellows/runtimes#56](https://github.com/polkadot-fellows/runtimes/pull/56))
+- Remove `experimental` feature flag for `pallet-society`, `pallet-xcm`, and `runtime-common` crates imports ([polkadot-fellows/runtimes#56](https://github.com/polkadot-fellows/runtimes/pull/56))
+- Election provider: use a geometric deposit base calculation for EPM signed submissions in Polkadot and Kusama ([polkadot-fellows/runtimes#56](https://github.com/polkadot-fellows/runtimes/pull/56))
+
+### Added
+
+- Add missing weight functions for `runtime_parachains_hrmp` and `preimage` pallets ([polkadot-fellows/runtimes#56](https://github.com/polkadot-fellows/runtimes/pull/56))


This should go into a new [Unreleased] header.

bkchr · 2023-11-20T20:00:27Z

/merge

paritytech-review-bot · 2023-11-20T20:00:59Z

There was a problem running the action.

❌😵❌

Please find more information in the logs.

@liamaharon

Opening PR mostly for visibility - I expect #56 to be finished before, which would bump everything to v1.2 and then I'll convert this PR to v1.2 -> v1.3. In its current state, this PR does v1.0 -> v1.3 bump, although I've only been looking at [v1.2 -> v1.3 changelog](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.3.0), so everything else just compiles. TODOs left in this PR (which I'd like to address after #56 is finished): - [x] revert `[cargo upgrade --pinned --incompatible](https://github.com/polkadot-fellows/runtimes/commit/8df27a586b598d2f783b53cd62b127b8f8ac846a)` and only leave sdk crates bump; - [x] rebase on top of #56; - [x] ensure that remaining PRs from v1.2 -> v1.3 are either not required for P/K or shall be added later (paritytech/polkadot-sdk#1344, paritytech/polkadot-sdk#1333); - [x] update weights - [x] ~(maybe worth a separate PR) there's a lot of unused weight files in this repo - I'd like to remove it~ will do it in a separate PR - tracked here: https://github.com/svyatonik/runtimes/tree/remove-unused-weight-files @liamaharon Can you, please, confirm that the paritytech/polkadot-sdk#1344 was necessary only for sdk CI fixes - that PR caught my eye when I was looking at 1.3 CHANGELOG and I was wondering if we need to do the same for Polkadot, Kusama and system parachains? --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: muharem <ismailov.m.h@gmail.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>

We imported the runtimes into this repo at tag [`v1.1.0-rc2`](https://github.com/paritytech/polkadot-sdk/commits/v1.1.0-rc2/) but still merged stuff until they got removed in [#1731](paritytech/polkadot-sdk#1731). This re-applies all changes in that commit range [`v1.1.0-rc2..bf90cb0b`](paritytech/polkadot-sdk@v1.1.0-rc2...bf90cb0) checked in the SDK with `git log v1.1.0-rc2..bf90cb0b -- polkadot/runtime/`. Closes #112 Most changes got applied as part of #56, but two were missing: - paritytech/polkadot-sdk#1303 - <s>https://github.com/paritytech/polkadot-sdk/pull/1476</s> (reverted) <s>One [open Q](#67 (comment)) since there was a difference between [#1291](paritytech/polkadot-sdk#1291) and #67.</s> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

muharem and others added 6 commits October 4, 2023 12:33

upgrade to 1.2

61425fa

rename fix

1d69c08

use stable/non dev crates version

661a0be

Merge remote-tracking branch 'origin/main' into muharem-upgrade-to-1.2

06e3c4f

Remove para scheduler migration

b666613

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Update Lockfile

070df06

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

svyatonik mentioned this pull request Nov 3, 2023

Upgrade dependencies svyatonik/runtimes#2

Closed

bkchr mentioned this pull request Nov 6, 2023

1.1.0 Release #68

Closed

bkchr reviewed Nov 6, 2023

View reviewed changes

muharem mentioned this pull request Nov 8, 2023

The Ambassador Program #84

Closed

ggwpez added 3 commits November 9, 2023 12:48

Remove all migrations from the last releast

8f614ae

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Revert "Remove all migrations from the last releast"

5fe9e84

This reverts commit 8f614ae.

Only remove TODO

089069f

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

svyatonik mentioned this pull request Nov 13, 2023

Upgrade from v1.2 to v1.3 #87

Merged

5 tasks

acatangiu mentioned this pull request Nov 13, 2023

[P-K Bridge][code-complete] bridge with XCM passing and AHs asset transfer support paritytech/parity-bridges-common#2689

Closed

11 tasks

bkontur mentioned this pull request Nov 13, 2023

ExpectPallet instruction benchmark is failing when using sdk using crates.io paritytech/polkadot-sdk#2284

Closed

2 tasks

gavofyork closed this Nov 14, 2023

gavofyork reopened this Nov 14, 2023

Sophia-Gold mentioned this pull request Nov 15, 2023

Enable async backing on Kusama #90

Closed

Merge branch 'main' into muharem-upgrade-to-1.2

befbda4

bkchr approved these changes Nov 20, 2023

View reviewed changes

Comment thread relay/kusama/src/lib.rs Outdated

Comment thread relay/polkadot/src/lib.rs Outdated

Comment thread relay/kusama/src/lib.rs Outdated

Apply suggestions from code review

f0ea4d4

Co-authored-by: Bastian Köcher <git@kchr.de>

eskimor approved these changes Nov 20, 2023

View reviewed changes

seunlanlege approved these changes Nov 20, 2023

View reviewed changes

Merge branch 'main' into muharem-upgrade-to-1.2

a75bc4c

joepetrowski approved these changes Nov 20, 2023

View reviewed changes

bkchr requested a review from ggwpez November 20, 2023 16:24

ggwpez approved these changes Nov 20, 2023

View reviewed changes

changelog

374361c

joepetrowski reviewed Nov 20, 2023

View reviewed changes

Comment thread CHANGELOG.md Outdated

Apply suggestions from code review

31de800

Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

bkchr requested changes Nov 20, 2023

View reviewed changes

muharem added 2 commits November 20, 2023 20:42

changelog - unrelease header

05bec54

use Fixed header for missing weight functions

271ed5c

bkchr approved these changes Nov 20, 2023

View reviewed changes

bkchr merged commit bdcd039 into polkadot-fellows:main Nov 20, 2023

muharem mentioned this pull request Nov 22, 2023

single PR on polkadot-sdk version update #101

Open

s0me0ne-unkn0wn mentioned this pull request Jan 5, 2024

CI: Enable try-runtime idempotency check #133

Merged

ggwpez mentioned this pull request Jan 30, 2024

Reapply changes since v1.1.0-rc2 import #172

Merged

Conversation

muharem commented Oct 4, 2023 • edited by ggwpez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkchr Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

acatangiu Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkchr Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

ggwpez Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

bkchr Nov 9, 2023

Choose a reason for hiding this comment

Uh oh!

acatangiu commented Nov 9, 2023

Uh oh!

ggwpez commented Nov 9, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paritytech-review-bot Bot commented Nov 20, 2023

There was a problem running the action.

Uh oh!

bkchr commented Nov 20, 2023

Uh oh!

muharem commented Nov 20, 2023

Uh oh!

Uh oh!

bkchr Nov 20, 2023

Choose a reason for hiding this comment

Uh oh!

muharem Nov 20, 2023

Choose a reason for hiding this comment

Uh oh!

bkchr commented Nov 20, 2023

Uh oh!

paritytech-review-bot Bot commented Nov 20, 2023

There was a problem running the action.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

muharem commented Oct 4, 2023 •

edited by ggwpez

Loading

acatangiu Nov 6, 2023 •

edited

Loading