Release 1.4.1 by bkchr · Pull Request #608 · polkadot-fellows/runtimes

bkchr · 2025-02-27T10:02:35Z

There was a bug found in the staking system which needs to be fixed ASAP. This release pulls in changes directly from a custom Polkadot-SDK branch. The changes can be reviewed here.

After approval, this will go out as a release immediately. A full disclosure of the impact of this issue will be released after it was applied on chain.

kianenigma · 2025-02-27T10:34:10Z

Doing some last checks on this, please wait.

bkchr · 2025-02-27T13:01:57Z

/merge

fellowship-merge-bot · 2025-02-27T13:05:38Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

pandres95 · 2025-03-11T06:46:30Z

@bkchr do you know if these changes will go out soon (maybe in stable2412-3? Apparently, #606 would be blocked until then.

bkchr · 2025-03-11T07:17:29Z

@Ank4n can answer this. I requested that this gets backported, but I don't know if this already happened.

Ank4n · 2025-03-12T00:39:13Z

@bkchr do you know if these changes will go out soon (maybe in stable2412-3? Apparently, #606 would be blocked until then.

@pandres95 it is already backported in the stable2412 branch and should be included in the next 2412 release.

As part of this change, we will need to setup a filter (associated function) for pallet_staking as shown in this example.

seadanda · 2025-03-12T08:45:07Z

should be included in the next 2412 release

It will be included as part of the 2412 patch release next Thursday (20th)

@Ank4n

This PR contains: - bump to stable2409-6 ## TODO: - [x] fix penpal-runtime compilation https://github.com/polkadot-fellows/runtimes/actions/runs/13853959747/job/38766523729?pr=623 - [x] check electra setup - [x] confirm that this PR is compatible and doing the same as #608 (@Ank4n) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>

@Ank4n

* Bump to stable2409-6 (polkadot-fellows#623) This PR contains: - bump to stable2409-6 ## TODO: - [x] fix penpal-runtime compilation https://github.com/polkadot-fellows/runtimes/actions/runs/13853959747/job/38766523729?pr=623 - [x] check electra setup - [x] confirm that this PR is compatible and doing the same as polkadot-fellows#608 (@Ank4n) --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> * Format --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>

@franciscoaguirre

This Pull Request provides a minimal set of changes to support the upgrade to `stable2412` (to the latest available patch). ## Notable changes Here are the most notable changes: - `sp-std` removed for every runtime (except Encointer). Now we use `core` or `alloc` instead. - Mocked weights for `frame_system_extensions`, `pallet_transaction_payment`, and `xcm` on most runtimes. - Mocked weights for `pallet_identity` on People runtimes. - Update to XCMv5 started. ## Notable TODOs - [x] ~Review whether we need to make more changes regarding XCMv5~ (moved to a follow-up PR). @franciscoaguirre - [x] In Asset Hubs, the benchmarking options for `pallet-asset-conversion-tx-payment` is not exposed (or at least, is raising errors when trying to add it). - [x] For `polkadot-runtime`, do we still need `coretime_migration.rs`? @seadanda - [x] Assist with the initial implementation of `TransactionExtension` @georgepisaltu @gui1117 ## Open Question - Shouldn't we start using `frame`, `#[frame_construct_runtime]` and `#[derive_impl]` since they've already been proven to work? ## Help needed - [x] @clangenb to update and re-enable Encointer. ## Action List - [x] ~Remove any reference to either `NetworkId::Westend` and `NetworkId::Rococo` and replace with `NetworkId::ByGenesis`~ (moved to a follow-up PR). - [x] Upgrade to `stable2412-3` - [x] Setup filter for pallet-staking to exclude pool members. See comment [here](#608 (comment)). ## Follow-up PRs - [ ] Refresh weights (to do before this release). ;) - [ ] Move to XCMv5. - [ ] Remove `sp-std`. --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: clangenb <37865735+clangenb@users.noreply.github.com> Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Alexandre Baldé <alexandre.balde@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

@franciscoaguirre

This Pull Request provides a minimal set of changes to support the upgrade to `stable2412` (to the latest available patch). ## Notable changes Here are the most notable changes: - `sp-std` removed for every runtime (except Encointer). Now we use `core` or `alloc` instead. - Mocked weights for `frame_system_extensions`, `pallet_transaction_payment`, and `xcm` on most runtimes. - Mocked weights for `pallet_identity` on People runtimes. - Update to XCMv5 started. ## Notable TODOs - [x] ~Review whether we need to make more changes regarding XCMv5~ (moved to a follow-up PR). @franciscoaguirre - [x] In Asset Hubs, the benchmarking options for `pallet-asset-conversion-tx-payment` is not exposed (or at least, is raising errors when trying to add it). - [x] For `polkadot-runtime`, do we still need `coretime_migration.rs`? @seadanda - [x] Assist with the initial implementation of `TransactionExtension` @georgepisaltu @gui1117 ## Open Question - Shouldn't we start using `frame`, `#[frame_construct_runtime]` and `#[derive_impl]` since they've already been proven to work? ## Help needed - [x] @clangenb to update and re-enable Encointer. ## Action List - [x] ~Remove any reference to either `NetworkId::Westend` and `NetworkId::Rococo` and replace with `NetworkId::ByGenesis`~ (moved to a follow-up PR). - [x] Upgrade to `stable2412-3` - [x] Setup filter for pallet-staking to exclude pool members. See comment [here](polkadot-fellows/runtimes#608 (comment)). ## Follow-up PRs - [ ] Refresh weights (to do before this release). ;) - [ ] Move to XCMv5. - [ ] Remove `sp-std`. --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: clangenb <37865735+clangenb@users.noreply.github.com> Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Clara van Staden <claravanstaden64@gmail.com> Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Co-authored-by: Alexandre Baldé <alexandre.balde@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

bkchr added 7 commits February 26, 2025 19:34

Do something

53103fc

Do some cleanups

4724e69

Update to the real thing

12185b8

Update Changelog

32b3f35

Update spec versions

a68b9b3

Update to the latest changes

725f4d3

MIGHTY TAPLO, PLEASE ACCEPT MY SACRIFICE

e541302

xlc approved these changes Feb 27, 2025

View reviewed changes

sandreim approved these changes Feb 27, 2025

View reviewed changes

Fix tests

af90a0a

ggwpez approved these changes Feb 27, 2025

View reviewed changes

Update again

ac1277e

Ank4n approved these changes Feb 27, 2025

View reviewed changes

joepetrowski approved these changes Feb 27, 2025

View reviewed changes

fellowship-merge-bot Bot merged commit 80ee7dc into main Feb 27, 2025

kianenigma mentioned this pull request Feb 27, 2025

Testing: Staking Guardrails #610

Open

bkchr deleted the bkchr-fix-the-thing branch March 11, 2025 19:15

Ank4n mentioned this pull request Mar 12, 2025

Upgrade polkadot sdk to stable2412-4 (rel. 1.5.0) #606

Merged

11 tasks

bkontur mentioned this pull request Mar 14, 2025

Bump to stable2409-6 #623

Merged

3 tasks

anaelleltd added this to Runtime releases Apr 16, 2025

github-project-automation Bot moved this to Todo in Runtime releases Apr 16, 2025

anaelleltd moved this from Todo to Done in Runtime releases Apr 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 1.4.1#608

Release 1.4.1#608
fellowship-merge-bot[bot] merged 9 commits into
mainfrom
bkchr-fix-the-thing

bkchr commented Feb 27, 2025 •

edited

Loading

Uh oh!

kianenigma commented Feb 27, 2025

Uh oh!

bkchr commented Feb 27, 2025

Uh oh!

fellowship-merge-bot Bot commented Feb 27, 2025

Uh oh!

pandres95 commented Mar 11, 2025

Uh oh!

bkchr commented Mar 11, 2025

Uh oh!

Ank4n commented Mar 12, 2025

Uh oh!

seadanda commented Mar 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

bkchr commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kianenigma commented Feb 27, 2025

Uh oh!

bkchr commented Feb 27, 2025

Uh oh!

fellowship-merge-bot Bot commented Feb 27, 2025

Uh oh!

pandres95 commented Mar 11, 2025

Uh oh!

bkchr commented Mar 11, 2025

Uh oh!

Ank4n commented Mar 12, 2025

Uh oh!

seadanda commented Mar 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

bkchr commented Feb 27, 2025 •

edited

Loading