[Encointer] use XCM V5 to remotely spend funds from encointer treasury accounts on AHK by clangenb · Pull Request #679 · polkadot-fellows/runtimes

clangenb · 2025-04-17T12:26:17Z

Encointer's treasury beneficiaries would greatly benefit from receiving assets directly on asset hub (especially in the future, as we can assume that CEX exchanges will allow deposits from asset hub). Additionally, we want to give them stability by receiving funds in stable coins (potentially dUSD).

The remote transfer has been inspired by the fellowships approach, however, it is slightly different as encointer has to pay for that execution. Additionally, we need to have a configurable sender account on Asset Hub, as each encointer-community has its own unique treasury account. Similarly to the polkadot-sdk's pay trait, we have introduced the Transfer trait (mostly in order to allow for a configurable sender account on asset hub). Which we intend to upstream after testing and deploying it here.

The idea is that the following happens on asset hub:

Descend into the origin of the encointer-treasury account's representation on asset hub
Withdraw some native tokens to pay for the fees
Withdraw the token to be transferred from the treasury-account to the beneficiary
Transfer: treasury -> beneficiary
Refund the excess weight

Changes in this PR:

Integrate Add new Proposal Types SpendAsset and IssueSwapAssetOption and abstract payment mechanism behind trait encointer/pallets#422 and enable transferring remotely on asset hub from the encointer runtime
Add an encointer-kusama-emulated chain to test
Add integration tests
- Verify that hardcoded remote execution fee of the remote transfer is correct
- Execute Remote transfer on Assethub
- Add some more XCM integration tests inspired by the other runtimes

Todo:

After testing, publish encointers crate enabling that feature and remove patches

This reverts commit 8814143.

ggwpez

Encointer is not a trusted teleporter, or?

acatangiu · 2025-08-22T14:30:45Z

Encointer is not a trusted teleporter, or?

it is a trusted teleporter, it's para id is in the sys chains interval, and that's what's used for differentiating trusted teleporters

also a trusted teleported for Kusama RC

… = true

clangenb · 2025-08-22T15:49:42Z

I think that the comments are addressed. Thanks for pointing this out!

acatangiu · 2025-08-23T06:28:25Z

/merge

pandres95

LGTM 👍

bkontur · 2025-08-25T08:53:28Z

+
+	let sender = AccountId::new([1u8; 32]);
+	let sender_location_on_target =
+		Location::new(1, X2([Parachain(42), AccountId32 { network: None, id: [1; 32] }].into()));


@clangenb just an nit, using too low values for parachain could be tricky in some scenarios (bellow 2000 are considered system parachains).

Good point. I copied this from upstreams Pay unit test. However, the Pay trait assumes free execution on the target parachain, so hence it was a reasonable assumption to put 42 as the parachain. I will make this a higher number when I move these tests upstream. 👍

bkontur · 2025-08-25T08:56:16Z

+	pub Timeout: BlockNumber = 5; // 5 blocks
+}
+
+/// Scenario:


@clangenb I didn't walk through these test, but just curios, if we could use emulated tests (EncointerKusama, AssetHubKusama, AssetHubPolkadot, PenpalKusama, PenpalPolkadot) to simulate this? That way we won't need all this mocking stuff.

I intend to upstream the Transfer trait and a TransferOverXCM generic implementation. In that process, I will move this test upstream. There is already mocking in place there, which I intend to re-use.

I agree with you that we can then delete the mocking and this unit test from here. 👍

bkontur · 2025-08-25T09:33:20Z

+			ReportError(QueryResponseInfo {
+				destination: destination.clone(),
+				query_id,
+				max_weight: Weight::zero(),


@clangenb is Weight::zero() really working? If I am checking it correctly, it should end up in the: https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/pallet-xcm/src/lib.rs#L4052-L4064

if weight.any_gt(max_weight) { let e = Event::NotifyOverweight {

Ok, maybe not that critical if the ReportError does not work, but still :)

Hmm, interesting. I suspect that the mock that I copied from upstream is lacking some logic here. I will have a closer look here while upstreaming that part. 👍

bkontur · 2025-08-25T09:34:59Z

+		//  Measured:  `733`
+		//  Estimated: `6196`
+		// Minimum execution time: 70_344_000 picoseconds.
+		Weight::from_parts(72_445_000, 0)


@clangenb Did we run fresh benchmarks for this? I think we should better run maybe as follow up - with mentioned small nits

Good catch, you are right. This call has not been properly benchmarked! Do I as a mere rank I member have the rights to run the benchmarks?

... Do I as a mere rank I member have the rights to run the benchmarks?

Yes, you can :)

@bkontur

@bkontur identified minor fixes after #679, which should be fixed. The most important one would be to properly generate the weight of the new dispatchable. Closes #864.   - [x] Does not require a CHANGELOG entry

clangenb added 19 commits April 17, 2025 09:45

patch encointer deps

7953a59

add first draft of xcm treasury payment

4072d93

minor fix

9cd0513

add withdraw asset

000dba5

some improvements, still getting lacking funds error

ce8852a

almost compiling version of the unit tests

0a07a17

compiles and xcm message is the expected

7779ed0

ensure that the account has balance

83e14f5

fix unused warnings

423213b

Rename to TransferRemoteViaXcm and make the type more generic

2af4bd9

minor improvements for the test fixes

248821e

add debugging and uncover why withdrawing does not work.

18682a4

integrate changes from pallets

f6581c4

some renaming

3543011

successfully transfer funds remotely

86828c8

add comment about fee handling

0bf8300

successfully pay back the withdrawer, but the amount seems off

6b479cc

put the refund surplus and deposit in the appendix

339f0d9

some renaming and cosmetics

ae609af

clangenb marked this pull request as draft April 17, 2025 12:26

clangenb added 4 commits April 17, 2025 14:36

fmt

8e5aa31

fix zepter

fd3b44f

fix TransferOverXcm implementation

0018a15

fmt

7648ad6

clangenb commented Apr 17, 2025

View reviewed changes

Comment thread system-parachains/encointer/src/tests/xcm_mock.rs

Comment thread system-parachains/encointer/src/treasuries_xcm_payout.rs

Comment thread system-parachains/encointer/src/treasuries_xcm_payout.rs Outdated

Comment thread system-parachains/encointer/src/tests/unit_tests.rs Outdated

clangenb changed the title ~~[Encointer] use XCM V5 to remotely transfer funds from encointer treasury accounts~~ [Encointer] use XCM V5 to remotely spend funds from encointer treasury accounts Apr 17, 2025

clangenb added 4 commits April 17, 2025 15:16

taplo fmt

cce9563

clippy

8f0f0ac

bump encointer

bbfdb74

fix benchmark

ea61c94

clangenb and others added 10 commits August 21, 2025 20:51

re-introduce hashed description.

abce776

Fix Changelog entry

cae3ea1

Revert "remove encointer-pallet patches"

baa0630

This reverts commit 8814143.

bump encointer to fix integritee-tests

ea2a28c

add benchmark helper to Paymaster (builds)

96e75d8

add encointer patches

69e64a8

Remove encointer patches

8f25618

Fix encointer-treasuries benchmarks

74e91ad

fmt

6ca9feb

Merge branch 'main' into cl/xcm-treasury-rebased

6cafb3c

ggwpez reviewed Aug 22, 2025

View reviewed changes

Comment thread integration-tests/emulated/tests/encointer/encointer-kusama/src/tests/mod.rs Outdated

ggwpez reviewed Aug 22, 2025

View reviewed changes

Comment thread system-parachains/encointer/Cargo.toml Outdated

ggwpez approved these changes Aug 22, 2025

View reviewed changes

polkadot-fellows deleted a comment from fellowship-merge-bot Bot Aug 22, 2025

clangenb added 2 commits August 22, 2025 17:43

encointer runtime: replace features = ["std"] with default-features…

21b1e14

… = true

remove encointer licence in the integration tests

6470710

remove default features from parachain-runtimes-test-utils

79747b1

acatangiu merged commit 67dc0c5 into polkadot-fellows:main Aug 23, 2025
63 of 64 checks passed

pandres95 reviewed Aug 25, 2025

View reviewed changes

bkontur reviewed Aug 25, 2025

View reviewed changes

clangenb mentioned this pull request Aug 28, 2025

[Tracking issue] XCM documentation paritytech/polkadot-sdk#9431

Open

10 tasks

bkontur mentioned this pull request Oct 5, 2025

[Encointer] fix treasury asset payment #944

Merged

clangenb deleted the cl/xcm-treasury-rebased branch December 3, 2025 06:09

Conversation

clangenb commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in this PR:

Todo:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ggwpez left a comment

Choose a reason for hiding this comment

Uh oh!

acatangiu commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clangenb commented Aug 22, 2025

Uh oh!

acatangiu commented Aug 23, 2025

Uh oh!

Uh oh!

pandres95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

clangenb commented Apr 17, 2025 •

edited

Loading

acatangiu commented Aug 22, 2025 •

edited

Loading