Weight update for 1.6 by ggwpez · Pull Request #769 · polkadot-fellows/runtimes

ggwpez · 2025-06-16T13:56:33Z

Updated on ref hw. subweight weight compare link (will 404 once this is merged).

TODOs from @bkontur:

generate xcm benchmarks for all runtimes (we can use bot just with --pallet pallet_xcm_bencmarks::fungible pallet_xcm_bencmarks::generic), because they are missing
- triggered here: Weight update for 1.6 #769 (comment)
investigate add add_authorized_alias/remove_authorized_alias why there is Weight::MAX, for AHP Aliasers are set as AliasChildLocation (I will check tomorrow)
Weight::MAX is ok, because of stable2503 bump introduced type AuthorizedAliasConsideration = Disabled;, which means that this feature is still in fellows inegration queue/backlog not yet integrated and these two PRs (pallet-xcm: add support to authorize aliases paritytech/polkadot-sdk#6336, [XCM] allow signed account to be aliased between system chains paritytech/polkadot-sdk#7983) need to be ported to the fellows repo (any volunteers are welcome!!!)
Does not require a CHANGELOG entry

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

bkontur · 2025-06-16T14:38:23Z

/cmd --runtime kusama --pallet frame_benchmarking::baseline frame_system frame_system_extensions

bkontur · 2025-06-16T14:38:37Z

/cmd --runtime kusama --pallet pallet_asset_rate pallet_bags_list pallet_balances pallet_beefy_mmr pallet_bounties pallet_child_bounties pallet_fast_unstake pallet_indices pallet_message_queue pallet_multisig pallet_nis

bkontur · 2025-06-16T14:38:48Z

/cmd --runtime kusama --pallet pallet_offences pallet_parameters pallet_preimage pallet_proxy pallet_recovery pallet_referenda pallet_scheduler pallet_session pallet_society pallet_staking pallet_timestamp pallet_transaction_payment pallet_treasury pallet_utility pallet_vesting pallet_whitelist pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic

bkontur · 2025-06-16T14:38:59Z

/cmd --runtime kusama --pallet pallet_ranked_collective pallet_nomination_pools frame_election_provider_support pallet_conviction_voting pallet_election_provider_multi_phase

bkontur · 2025-06-16T14:39:07Z

/cmd --runtime kusama --pallet polkadot_runtime_common::auctions polkadot_runtime_common::claims polkadot_runtime_common::crowdloan polkadot_runtime_common::paras_registrar polkadot_runtime_common::slots

bkontur · 2025-06-16T14:39:14Z

/cmd --runtime kusama --pallet runtime_parachains::configuration runtime_parachains::coretime runtime_parachains::disputes runtime_parachains::disputes::slashing runtime_parachains::hrmp runtime_parachains::initializer

bkontur · 2025-06-16T14:39:22Z

/cmd --runtime kusama --pallet runtime_parachains::on_demand runtime_parachains::paras

bkontur · 2025-06-16T14:39:28Z

/cmd --runtime kusama --pallet runtime_parachains::inclusion

bkontur · 2025-06-16T14:39:32Z

/cmd --runtime kusama --pallet runtime_parachains::paras_inherent

github-actions · 2025-06-16T15:17:14Z

Command "--runtime kusama --pallet frame_benchmarking::baseline frame_system frame_system_extensions" has started 🚀 See logs here

github-actions · 2025-06-16T15:17:18Z

Command "--runtime kusama --pallet frame_benchmarking::baseline frame_system frame_system_extensions" has failed ❌! See logs here

github-actions · 2025-06-16T15:17:30Z

Command "--runtime kusama --pallet pallet_asset_rate pallet_bags_list pallet_balances pallet_beefy_mmr pallet_bounties pallet_child_bounties pallet_fast_unstake pallet_indices pallet_message_queue pallet_multisig pallet_nis" has started 🚀 See logs here

github-actions · 2025-06-16T15:17:34Z

Command "--runtime kusama --pallet pallet_asset_rate pallet_bags_list pallet_balances pallet_beefy_mmr pallet_bounties pallet_child_bounties pallet_fast_unstake pallet_indices pallet_message_queue pallet_multisig pallet_nis" has failed ❌! See logs here

github-actions · 2025-06-16T15:17:44Z

Command "--runtime kusama --pallet pallet_offences pallet_parameters pallet_preimage pallet_proxy pallet_recovery pallet_referenda pallet_scheduler pallet_session pallet_society pallet_staking pallet_timestamp pallet_transaction_payment pallet_treasury pallet_utility pallet_vesting pallet_whitelist pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic" has started 🚀 See logs here

github-actions · 2025-06-16T15:17:46Z

Command "--runtime kusama --pallet pallet_ranked_collective pallet_nomination_pools frame_election_provider_support pallet_conviction_voting pallet_election_provider_multi_phase" has started 🚀 See logs here

github-actions · 2025-06-16T15:17:48Z

Command "--runtime kusama --pallet pallet_offences pallet_parameters pallet_preimage pallet_proxy pallet_recovery pallet_referenda pallet_scheduler pallet_session pallet_society pallet_staking pallet_timestamp pallet_transaction_payment pallet_treasury pallet_utility pallet_vesting pallet_whitelist pallet_xcm pallet_xcm_benchmarks::fungible pallet_xcm_benchmarks::generic" has failed ❌! See logs here

github-actions · 2025-06-16T15:17:50Z

Command "--runtime kusama --pallet pallet_ranked_collective pallet_nomination_pools frame_election_provider_support pallet_conviction_voting pallet_election_provider_multi_phase" has failed ❌! See logs here

github-actions · 2025-06-16T15:18:01Z

Command "--runtime kusama --pallet runtime_parachains::configuration runtime_parachains::coretime runtime_parachains::disputes runtime_parachains::disputes::slashing runtime_parachains::hrmp runtime_parachains::initializer" has started 🚀 See logs here

github-actions · 2025-06-16T15:18:04Z

Command "--runtime kusama --pallet runtime_parachains::configuration runtime_parachains::coretime runtime_parachains::disputes runtime_parachains::disputes::slashing runtime_parachains::hrmp runtime_parachains::initializer" has failed ❌! See logs here

github-actions · 2025-06-16T15:18:07Z

Command "--runtime kusama --pallet polkadot_runtime_common::auctions polkadot_runtime_common::claims polkadot_runtime_common::crowdloan polkadot_runtime_common::paras_registrar polkadot_runtime_common::slots" has started 🚀 See logs here

github-actions · 2025-06-16T15:18:15Z

Command "--runtime kusama --pallet runtime_parachains::on_demand runtime_parachains::paras" has started 🚀 See logs here

github-actions · 2025-06-16T15:18:15Z

Command "--runtime kusama --pallet polkadot_runtime_common::auctions polkadot_runtime_common::claims polkadot_runtime_common::crowdloan polkadot_runtime_common::paras_registrar polkadot_runtime_common::slots" has failed ❌! See logs here

github-actions · 2025-06-16T15:18:25Z

Command "--runtime kusama --pallet runtime_parachains::on_demand runtime_parachains::paras" has failed ❌! See logs here

github-actions · 2025-06-16T15:18:27Z

Command "--runtime kusama --pallet runtime_parachains::inclusion" has started 🚀 See logs here

github-actions · 2025-06-16T15:18:31Z

Command "--runtime kusama --pallet runtime_parachains::inclusion" has failed ❌! See logs here

github-actions · 2025-06-16T15:18:33Z

Command "--runtime kusama --pallet runtime_parachains::paras_inherent" has started 🚀 See logs here

github-actions · 2025-06-16T15:18:36Z

Command "--runtime kusama --pallet runtime_parachains::paras_inherent" has failed ❌! See logs here

bkontur · 2025-06-16T16:03:43Z

/cmd bench --runtime kusama --pallet frame_benchmarking::baseline frame_system frame_system_extensions

ggwpez · 2025-06-17T12:33:09Z

/cmd clean

ordian · 2025-06-17T12:43:40Z

+	/// Storage: `Staking::SlashingSpans` (r:513 w:513)
+	/// Proof: `Staking::SlashingSpans` (`max_values`: None, `max_size`: None, mode: `Measured`)
+	/// Storage: `Staking::SpanSlash` (r:513 w:513)
+	/// Proof: `Staking::SpanSlash` (`max_values`: None, `max_size`: Some(76), added: 2551, mode: `MaxEncodedLen`)
+	/// Storage: `Staking::NominatorSlashInEra` (r:512 w:512)
+	/// Proof: `Staking::NominatorSlashInEra` (`max_values`: None, `max_size`: Some(68), added: 2543, mode: `MaxEncodedLen`)
+	/// Storage: `Staking::UnappliedSlashes` (r:1 w:1)
+	/// Proof: `Staking::UnappliedSlashes` (`max_values`: None, `max_size`: None, mode: `Measured`)
 	fn manual_slash() -> Weight {
 		// Proof Size summary in bytes:
-		//  Measured:  `514`
-		//  Estimated: `4175`
-		// Minimum execution time: 30_000_000 picoseconds.
-		Weight::from_parts(33_000_000, 4175)
-			.saturating_add(T::DbWeight::get().reads(10_u64))
-			.saturating_add(T::DbWeight::get().writes(4_u64))
+		//  Measured:  `20713`
+		//  Estimated: `1309653`
+		// Minimum execution time: 7_768_872_000 picoseconds.
+		Weight::from_parts(7_843_282_000, 0)
+			.saturating_add(Weight::from_parts(0, 1309653))
+			.saturating_add(T::DbWeight::get().reads(1549))
+			.saturating_add(T::DbWeight::get().writes(1540))


1.5k reads and writes looks.. wrong.
it probably won't allow a single such extrinsic into a block

actually, it's not that bad, "only" ~200ms

Shouldn't this benchmark use for example l: Linear<1 .. 10> for nominators count or something? Or nominators counts does not affect this?

#[benchmark] fn manual_slash() -> Result<(), BenchmarkError> { // Create a validator with nominators // This will add exposure for our validator in the current era. let (validator_stash, _nominators) = create_validator_with_nominators::<T>(

#[test] fn create_validator_with_nominators_works() { ExtBuilder::default().build_and_execute(|| { let n = 10; let (validator_stash, nominators) = create_validator_with_nominators::<Test>( n,

Shouldn't this benchmark use for example l: Linear<1 .. 10> for nominators count or something? Or nominators counts does not affect this?

We should assume the worst case scenario when slashing a validator that it has maximally allowed number of nominators. I think the problem is that offence processing code is linear in the number of nominators - this should be fixed with AHM and staking-async pallet since PoV size is limited.

ordian · 2025-06-17T12:44:37Z

+	/// Storage: `Staking::SlashingSpans` (r:513 w:513)
+	/// Proof: `Staking::SlashingSpans` (`max_values`: None, `max_size`: None, mode: `Measured`)
+	/// Storage: `Staking::SpanSlash` (r:513 w:513)
+	/// Proof: `Staking::SpanSlash` (`max_values`: None, `max_size`: Some(76), added: 2551, mode: `MaxEncodedLen`)
+	/// Storage: `Staking::NominatorSlashInEra` (r:512 w:512)
+	/// Proof: `Staking::NominatorSlashInEra` (`max_values`: None, `max_size`: Some(68), added: 2543, mode: `MaxEncodedLen`)
+	/// Storage: `Staking::UnappliedSlashes` (r:1 w:1)
+	/// Proof: `Staking::UnappliedSlashes` (`max_values`: None, `max_size`: None, mode: `Measured`)
 	fn manual_slash() -> Weight {
 		// Proof Size summary in bytes:
-		//  Measured:  `514`
-		//  Estimated: `4175`
-		// Minimum execution time: 30_000_000 picoseconds.
-		Weight::from_parts(33_000_000, 4175)
-			.saturating_add(T::DbWeight::get().reads(10_u64))
-			.saturating_add(T::DbWeight::get().writes(4_u64))
+		//  Measured:  `20200`
+		//  Estimated: `1309653`
+		// Minimum execution time: 9_108_355_000 picoseconds.
+		Weight::from_parts(9_700_684_000, 0)
+			.saturating_add(Weight::from_parts(0, 1309653))
+			.saturating_add(T::DbWeight::get().reads(1549))
+			.saturating_add(T::DbWeight::get().writes(1540))
 	}


ordian

relay/{polkadot,kusama}/src/weights looks sane except for manual_slash, but that should not be a blocker - would be nice to autocheck for other anomalies like that

ggwpez · 2025-06-17T13:02:09Z

@ordian the PoV weight here is quite high, but I assume that it does not matter on the relay anyway.

ordian · 2025-06-17T13:04:38Z

ah, yeah, it might produce an annoying warning though, which is fixed in paritytech/polkadot-sdk#8861

(that number looks ridiculuosly high though haha)

github-actions · 2025-06-17T13:30:12Z

Command "clean" has started 🚀 See logs here

github-actions · 2025-06-17T13:30:16Z

Command "clean" has failed ❌! See logs here

This is leftover from bump stable2412 where we added Aliasers but not changed weights: #606 for AssetHub weights were fixed here #700 but not for other chains - [X] Does not require a CHANGELOG entry

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

acatangiu

Love the site/UI for seeing weight diffs ❤️

ggwpez · 2025-06-19T11:23:45Z

/merge

fellowship-merge-bot · 2025-06-19T11:39:52Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

acatangiu · 2025-06-19T11:58:48Z

/merge

looks like the bot merges even if CI is still running (15 of 61 checks passed)

ggwpez · 2025-06-19T12:02:05Z

Uh yea. Looks like they are not required. Will check again for CI in #761

Weights

c132849

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez marked this pull request as ready for review June 16, 2025 14:42

ordian reviewed Jun 17, 2025

View reviewed changes

ordian approved these changes Jun 17, 2025

View reviewed changes

bkontur and others added 2 commits June 17, 2025 16:10

Set up alias_origin weights correctly (#771)

599383a

This is leftover from bump stable2412 where we added Aliasers but not changed weights: #606 for AssetHub weights were fixed here #700 but not for other chains - [X] Does not require a CHANGELOG entry

Merge branch 'main' into oty-weights

2101600

ggwpez added this to Runtime releases Jun 17, 2025

github-project-automation Bot moved this to Todo in Runtime releases Jun 17, 2025

CHANGELOG

a00cc1e

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

ggwpez moved this from Todo to In Progress in Runtime releases Jun 18, 2025

ggwpez added 5 commits June 18, 2025 12:30

Merge remote-tracking branch 'origin/main' into oty-weights

b5b75f0

Fix test constants

147b9f4

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Revive revive weights

8e94eaa

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

Merge remote-tracking branch 'origin/main' into oty-weights

7f03946

Merge branch 'main' into oty-weights

ebc3668

bkontur approved these changes Jun 18, 2025

View reviewed changes

nkpar approved these changes Jun 19, 2025

View reviewed changes

athei approved these changes Jun 19, 2025

View reviewed changes

acatangiu approved these changes Jun 19, 2025

View reviewed changes

fix tests

1f579aa

fellowship-merge-bot Bot merged commit f23cdc0 into main Jun 19, 2025
61 checks passed

github-project-automation Bot moved this from In Progress to Done in Runtime releases Jun 19, 2025

Conversation

ggwpez commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

bkontur commented Jun 16, 2025

Uh oh!

ggwpez commented Jun 17, 2025

Uh oh!

ordian Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

ordian Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

bkontur Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

ordian Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

ordian Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

ordian left a comment

Choose a reason for hiding this comment

Uh oh!

ggwpez commented Jun 16, 2025 •

edited

Loading

ordian commented Jun 17, 2025 •

edited

Loading