stakerRewards bug | Payouts

[ironoa]

stakerRewards call may be broken, not filtering out the already claimed rewards

Likely related, the ui seems to be showing something wrong (I've just manually claimed for era 6528, 6527, 6526, but yet they are shown there)

As a double check, If I try to claim again I get indeed the the already claimed error

@polkadot/api version: v10.13.1

[ironoa]

I used to get the Rewards to be claimed like this, but now it seem to be deprecated and the note says to use EraInfo... any suggestion ?

[TarikGul]

Known issue. I am working on a fix to get the staking pages sorted and fixed.

[ironoa]

Thanks for the answer.

fyi maybe related: being connected with a kusama node on v1.10.0, performing this (this.api.derive.staking.query(validatorAddress,{withLedger:true})) I don't see the ClaimedRewards property, but just the legacyClaimedRewards. And the legacyClaimedRewards doesn't go past the 6,510 era => It may cause an issue here

[TarikGul]

Yea you definitely brought up a great point with the claimedRewards. I have been trying to clean it up in the derives for the past 3 hours as this is the last blocker until I can start pushing all these fixes downstream to the UI, but the change from legacy_claimed_rewards to ::ClaimedRewards is such a PITA given the current logic in the api.

I'll find some solution though 🤞

[TarikGul]

Fixed via #5862

[TarikGul]

this.api.derive.staking.query(validatorAddress,{withLedger:true, withClaimedRewardsEras: true}) Will add a claimedRewardsEras field. Then you can combine legacyClaimedRewards with claimedRewardsEras in order to see all the eras

[ironoa]

Thanks for the quick resolution, I indeed implemented it using this.api.derive.staking.query(validatorAddress,{withLedger:true, withClaimedRewardsEras: true})

For reference: https://github.com/w3f/polkadot-k8s-payouts/blob/v1.2.9/src/claimer.ts#L138-L171

---

Unfortunately, there seems to be a bug still: even if unclaimed rewards are spotted, one cannot claim anything before era 6514 (speaking about Kusama) due to an AlreadyClaimed error

• 6512, error
• 6513, error
• 6514, working
• 6515, working
• onward, working

For now, this is my temporary fix. However, it will prevent people from claiming rewards before era 6514.

UPDATE: Polkadot seems to have the same issue, one cannot claim before era 1420

• 1418, error
• 1419, error
• 1420, working
• 1421, working

---

Maybe related: paritytech/polkadot-sdk#1189

[TarikGul]

@Ank4n Have you anything similar to this? Pjs api is just returning legacyClaimedRewards, and the new ClaimedRewards from the node so I would doubt any of the data is wrong from the api side? Is there a new specific way for a user to claim those older rewards?

[Ank4n]

• 6512, error

Older rewards should work as usual. After the upgrade, all claimed rewards for eras are noted in the new storage ClaimedRewards. Older rewards are always treated as of 1 page.

For era 6512 your validator claimed reward here: https://kusama.subscan.io/extrinsic/22806784-2.

I didn't check all the links you posted but I think it might already be claimed which is why you are seeing the error (correctly). You should see an entry in ClaimedRewards storage for that era and stash to double check.

[ironoa]

• 6512, error

Older rewards should work as usual. After the upgrade, all claimed rewards for eras are noted in the new storage ClaimedRewards. Older rewards are always treated as of 1 page.

For era 6512 your validator claimed reward here: https://kusama.subscan.io/extrinsic/22806784-2.

I didn't check all the links you posted but I think it might already be claimed which is why you are seeing the error (correctly). You should see an entry in ClaimedRewards storage for that era and stash to double check.

this.api.derive.staking.query(validatorAddress,{withLedger:true, withClaimedRewardsEras: true}) Will add a claimedRewardsEras field. Then you can combine legacyClaimedRewards with claimedRewardsEras in order to see all the eras

Thanks for checking. But then I guess the problem is that nor legacyClaimedRewards nor claimedRewardsEras are showing that for era 6512 the reward has been claimed (code here)

[TarikGul]

Weirdly enough I do remember seeing something similar during testing where the era during the staking transition was missing within legacyClaimedRewards, and or claimedRewards. At the time I thought nothing of it since I assumed it was just unclaimed, but now it seems a bit weird.

I don't have the ability to verify what I saw right now since I am OOO for the next week. But definitely something to follow up on.

[Ank4n]

• 6512, error

Older rewards should work as usual. After the upgrade, all claimed rewards for eras are noted in the new storage ClaimedRewards. Older rewards are always treated as of 1 page.
For era 6512 your validator claimed reward here: https://kusama.subscan.io/extrinsic/22806784-2.
I didn't check all the links you posted but I think it might already be claimed which is why you are seeing the error (correctly). You should see an entry in ClaimedRewards storage for that era and stash to double check.

this.api.derive.staking.query(validatorAddress,{withLedger:true, withClaimedRewardsEras: true}) Will add a claimedRewardsEras field. Then you can combine legacyClaimedRewards with claimedRewardsEras in order to see all the eras

Thanks for checking. But then I guess the problem is that nor legacyClaimedRewards nor claimedRewardsEras are showing that for era 6512 the reward has been claimed (code here)

Probably bug with the derived api? If you query the storage directly you can see that it is claimed.

console.log((await api.query.staking.claimedRewards(6512, 'GaK38GT7LmgCpRSTRdDC2LeiMaV9TJmx8NmQcb9L3cJ3fyX')).length)
// returns 1