fix: Remove assert_eq! from BiDi ShapeLine for avoid crash#508
Open
NSTikhomirov wants to merge 3 commits into
Open
fix: Remove assert_eq! from BiDi ShapeLine for avoid crash#508NSTikhomirov wants to merge 3 commits into
NSTikhomirov wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmic-text can crash when certain characters show up in the editor view.
Error message:
Reproduce steps (commit
c24886c2471e5606587c46090cd25dbbf209186b):As I understand it, the assert expects all paragraphs in a line to have the same direction.
But for arbitrary text that's not always true, a line can split into paragraphs with different directions, and then it crashes on normal input.
And it seems this direction isn't really needed for correctness: the character order comes from the BiDi levels themselves, while the line direction is more for alignment and the ellipsis.
So I just removed the assert and shape the line by its base direction. No more panic, and normal lines look the same as before.