Skip to content

remove time without time zone from date type cast #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021
Merged

remove time without time zone from date type cast #255

merged 1 commit into from
Dec 28, 2021

Conversation

dilan-dio4
Copy link
Contributor

Time types are stored as strings that are not compatible in the new Date constructer. They don't need to be cast.

@porsager
Copy link
Owner

could you show an example where they are not compatible?

@porsager
Copy link
Owner

Haha, sorry, I read the topic as timestamp without time zone and not time. My bad. You're absolutely right, trying to cast time to js Date doesn't make any sense.

Thanks a lot for the PR!

@porsager porsager merged commit 99c1d74 into porsager:master Dec 28, 2021
@dilan-dio4
Copy link
Contributor Author

Thanks! @porsager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants