Drop 1.19 Kube version support and lower #160
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered an error creating an ingress with this chart saying
no matches for kind "Ingress" in version "networking.k8s.io/v1beta1". This appears to be an issue with this snippet checking the Kubernetes API version then setting the ingress API version. In my case I use K3S which has version likev1.31.2+k3s1which does not work with this check and incorrectly set the ingress versions tonetworking.k8s.io/v1beta1. Since that ingress version was dropped in 1.19 which came out in 2020 I thought it would be simpler to just drop support for 1.19 and lower and hard set the v1 API version. I have tested this change on my cluster then was able to create an ingress as expected.Fixes #88 and #58