Refactor: Trades view to use only TradeElements #5132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgemac-labs
force-pushed
the
refactor/trades-view-to-use-tradeelement
branch
2 times, most recently
from
56f5402 to
30ca395
Compare
georgemac-labs
force-pushed
the
refactor/trades-view-to-use-tradeelement
branch
from
59d2ac1 to
608b7db
Compare
Contributor
Author
|
@buchen I started to use sub-classifications in my taxonomies and noticed that my Trades implementation handles them in a weird way, and differently from other views (it flattens the tree and shows all classifications, with weird ordering). I'd like to fix that. Could you let me know if you envisage merging this PR? Then I would know which code to base the improvements on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@buchen I realised that I forgot the refactoring you suggested.
Have attempted it here. See what you think.