feat: Support pickling #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #641 +/- ##
=======================================
Coverage 91.18% 91.19%
=======================================
Files 47 47
Lines 5458 5460 +2
=======================================
+ Hits 4977 4979 +2
Misses 481 481 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@malcolmbarrett any chance you might be able to install and check if this does what you need? |
|
Works great for me! Thanks to you both |
machow
reviewed
Mar 21, 2025
great_tables/_gt_data.py
Outdated
| @@ -283,7 +283,10 @@ def __init__( | |||
| rowname_col: str | None = None, | |||
| groupname_col: str | None = None, | |||
| ): | |||
| pass | |||
| self._data = data | |||
There was a problem hiding this comment.
I feel like this __init__ quirk is related to how I put __new__ in, but I'm not totally sure how to fix it 😅
There was a problem hiding this comment.
@machow, thanks for the feedback! I think returning self._d for __getnewargs__ might be a more correct approach.
machow
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #640
This PR adds support for pickling
GT. The__getnewargs__method is relatively new to me, but the implementation appears to be straightforward.Edit: Based on the error message, it seems that providing only the
data=parameter is sufficient, but I'm unsure if the other three parameters—auto_align=,rowname_col=, andgroupname_col=—are also required.