Skip to content

Remove express.ui.output_* functions, add output args to render functions #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

wch
Copy link
Collaborator

@wch wch commented Jan 13, 2024

This PR does the following:

  • Removes the output_* functions from shiny.express.ui.
  • Adds arguments for the shiny.ui.output_* functions to the shiny.render.* functions.
  • Deprecates output_args(). (Probably no one is using this anyway.)

A few things yet to do:

  • Come up with a solution for name collisions for some render.* and output_* function arguments, like **kwargs, width, and height. kwargs handling should be consistent across all functions that use them: render_plot, render_image, render_table, render_ui, render_table, render_download
  • Update all default_ui() methods so that they only accept an id argument.
  • Resolve this message:
    # TODO-future; When `OutputRenderer` is removed, remove `output_args()`
  • Update remaining tests that use ui_kwargs.

@wch
Copy link
Collaborator Author

wch commented Jan 17, 2024

Closing in favor of #1018.

@wch wch closed this Jan 17, 2024
@wch wch deleted the render-output-args branch January 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant