Remove express.ui.output_*
functions, add output args to render functions
#1004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
output_*
functions fromshiny.express.ui
.shiny.ui.output_*
functions to theshiny.render.*
functions.output_args()
. (Probably no one is using this anyway.)A few things yet to do:
render.*
andoutput_*
function arguments, like**kwargs
,width
, andheight
.kwargs
handling should be consistent across all functions that use them:render_plot
,render_image
,render_table
,render_ui
,render_table
,render_download
default_ui()
methods so that they only accept anid
argument.py-shiny/shiny/render/transformer/_transformer.py
Line 3 in b4ed7ff
ui_kwargs
.