Update @add_examples() to work with Express, avoid Express docs example errors for now
#1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carson Sievert <[email protected]>
Co-authored-by: Carson Sievert <[email protected]>
Co-authored-by: Garrick Aden-Buie <[email protected]>
gshotwell
changed the title
gadenbuie
changed the title
@add_examples() to work with Express, avoid Express docs example errors for now
gadenbuie
commented
Jan 26, 2024
Comment on lines
+197
to
+198
| # We can't use .shiny.express._is_express.is_express_app() here because that would | ||
| # create a circular import. |
There was a problem hiding this comment.
Import here, avoid circular import
There was a problem hiding this comment.
Oof, this still gave me a circular import error
File "/Users/garrick/work/posit-dev/py-shiny/shiny/ui/_accordion.py", line 11, in <module>
from ..session import require_active_session
ImportError: cannot import name 'require_active_session' from partially initialized module 'shiny.session' (most likely due to a circular import) (/Users/garrick/work/posit-dev/py-shiny/shiny/session/__init__.py)
I'm going to leave this alone for now
|
Merged manually into #1053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1053