Skip to content

Force UTF-8 for Shiny Express on Windows #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Force UTF-8 for Shiny Express on Windows #1203

merged 3 commits into from
Mar 13, 2024

Conversation

jcheng5
Copy link
Collaborator

@jcheng5 jcheng5 commented Mar 7, 2024

No description provided.

@wch wch added this to the v0.9.0 milestone Mar 7, 2024
@wch
Copy link
Collaborator

wch commented Mar 13, 2024

Should check if there are other places we call open(file) to read in Python code.

@wch wch marked this pull request as ready for review March 13, 2024 22:31
@wch wch merged commit 518fc05 into main Mar 13, 2024
@wch wch deleted the utf8-windows branch March 13, 2024 22:32
schloerke added a commit that referenced this pull request Mar 15, 2024
* main:
  Add support for Shiny Express in Quarto Dashboards, take 2 (#1217)
  Force UTF-8 for Shiny Express on Windows (#1203)
  Typing fixes
  feat(card): Report full screen state as a Shiny input (#1215)
  Use TypeScript strict mode (#1208)
  Update author email
  test: Resolve testing comments (#1206)
  Fix URL
  Update badges
  Bump dev version to 0.8.1.9000 (#1202)
  chore(deps): Update bslib css (#1200)
  chore: no new features
  v0.8.1
schloerke added a commit to joesho112358/py-shiny that referenced this pull request Mar 23, 2024
* main: (24 commits)
  chore: Disable broken test on CI; Fix broken docs entries (posit-dev#1241)
  Add back missing session methods (posit-dev#1239)
  Add kitchensink tests for valuebox (posit-dev#1229)
  For Express, emit message if need to upgrade rsconnect-python (posit-dev#1233)
  feat: Editable data frame (posit-dev#1198)
  Add tests for shiny_mode comment detection
  fix(input_dark_mode): Allow users to customize `style` attribute (posit-dev#1207)
  chore(get_current_session): Return default session if current is explicitly None (posit-dev#1086)
  chore: use dev htmtlools (posit-dev#1228)
  feat(layout_columns): Use `sm` as the default `col_widths` breakpoint (posit-dev#1222)
  feat: ensure min/max height args on `value_box()` and column layouts (posit-dev#1223)
  fix(static_assets): Need the directory containing the `app.py`, not the file itself (posit-dev#1219)
  Update bslib and shiny dependencies (posit-dev#1221)
  Update docstring and give hint for mypy
  Add support for Shiny Express in Quarto Dashboards, take 2 (posit-dev#1217)
  Force UTF-8 for Shiny Express on Windows (posit-dev#1203)
  Typing fixes
  feat(card): Report full screen state as a Shiny input (posit-dev#1215)
  Use TypeScript strict mode (posit-dev#1208)
  Update author email
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants