Skip to content

build: set Narwhals 1.9.1 as minimum, remove upper bound, use narwhals.stable.v1 for dtypes and typing #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ dependencies = [
"prompt-toolkit;platform_system!='Emscripten'",
"python-multipart>=0.0.7;platform_system!='Emscripten'",
"setuptools;python_version>='3.12'",
"narwhals>=1.9.0,<1.10.0",
"narwhals>=1.9.1",
"orjson>=3.10.7",
]

Expand Down
10 changes: 5 additions & 5 deletions shiny/render/_data_frame_utils/_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@

import narwhals.stable.v1 as nw
from htmltools import TagNode
from narwhals.dtypes import DType as DType
from narwhals.typing import DataFrameT as DataFrameT
from narwhals.typing import IntoDataFrame as IntoDataFrame
from narwhals.typing import IntoDataFrameT as IntoDataFrameT
from narwhals.typing import IntoExpr as IntoExpr
from narwhals.stable.v1.dtypes import DType as DType
from narwhals.stable.v1.typing import DataFrameT as DataFrameT
from narwhals.stable.v1.typing import IntoDataFrame as IntoDataFrame
from narwhals.stable.v1.typing import IntoDataFrameT as IntoDataFrameT
from narwhals.stable.v1.typing import IntoExpr as IntoExpr

from ..._typing_extensions import Annotated, NotRequired, Required, TypedDict
from ...types import Jsonifiable, JsonifiableDict, ListOrTuple
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# pyright: reportArgumentType = false
# pyright: reportUnknownMemberType = false
import polars as pl
from narwhals.typing import IntoDataFrame
from narwhals.stable.v1.typing import IntoDataFrame
from palmerpenguins import load_penguins_raw

from shiny import App, Inputs, Outputs, Session, module, render, ui
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import pandas as pd
import polars as pl
import seaborn as sns
from narwhals.typing import IntoDataFrame
from narwhals.stable.v1.typing import IntoDataFrame

from shiny import App, Inputs, Outputs, Session, module, reactive, render, ui

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import palmerpenguins # pyright: ignore[reportMissingTypeStubs]
import polars as pl
from narwhals.typing import IntoDataFrame
from narwhals.stable.v1.typing import IntoDataFrame

from shiny import App, Inputs, Outputs, Session, module, reactive, render, ui

Expand Down
2 changes: 1 addition & 1 deletion tests/playwright/shiny/components/data_frame/styles/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# pyright: reportMissingTypeStubs = false
import palmerpenguins
import polars as pl
from narwhals.typing import IntoDataFrame
from narwhals.stable.v1.typing import IntoDataFrame

from shiny import App, Inputs, Outputs, Session, module, render, ui

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import palmerpenguins # pyright: ignore[reportMissingTypeStubs]
import polars as pl
from narwhals.typing import IntoDataFrame
from narwhals.stable.v1.typing import IntoDataFrame

from shiny import Inputs, Outputs, Session
from shiny.express import module, render, ui
Expand Down
2 changes: 1 addition & 1 deletion tests/pytest/test_render_data_frame_tbl_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ def test_subset_frame_cols_single(small_df_f: IntoDataFrame):
def test_dtype_coverage():
from pathlib import Path

from narwhals import dtypes as nw_dtypes
from narwhals.stable.v1 import dtypes as nw_dtypes

# Copy from https://github.com/narwhals-dev/narwhals/blob/2c9e2e7a308ebb30c6f672e27c1da2086ebbecbc/utils/check_api_reference.py#L144-L146
dtype_names = [
Expand Down
Loading