-
Notifications
You must be signed in to change notification settings - Fork 100
fix(tests): skip modin tests if python version == 3.13 #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR aims to prevent test failures related to modin support by skipping specific tests when running on Python 3.13. Key changes include:
- Adding a sys.version_info check and pytest.skipif decorator in two test files.
- Updating imports to support the addition of the skipif functionality.
Reviewed Changes
File | Description |
---|---|
tests/playwright/shiny/components/table/test_table.py | Added a skipif marker to skip table tests when running on Python ≥ 3.13 |
tests/playwright/shiny/components/data_frame/data_type/test_df_data_type.py | Added a skipif marker to skip data type tests when running on Python ≥ 3.13 |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
tests/playwright/shiny/components/data_frame/data_type/test_df_data_type.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…_data_type.py Co-authored-by: Copilot <[email protected]>
…py-shiny into skip-modin-3.13-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates test code to avoid failures in environments running Python 3.13 by skipping tests that require modin, which isn’t supported on that version. Key changes include:
- Adding a version check in table and data frame app files that conditionally imports modin or raises a RuntimeError.
- Decorating tests with a skip condition for Python 3.13.
- Aligning the test behavior to temporarily bypass modin-related failures.
Reviewed Changes
File | Description |
---|---|
tests/playwright/shiny/components/table/app.py | Adds a Python version check before importing modin; raises a RuntimeError on Python 3.13+. |
tests/playwright/shiny/components/table/test_table.py | Applies a skipif decorator for tests running on Python 3.13. |
tests/playwright/shiny/components/data_frame/data_type/app.py | Adds a similar Python version check for modin import, raising a RuntimeError for Python 3.13+. |
tests/playwright/shiny/components/data_frame/data_type/test_df_data_type.py | Applies a skipif decorator for tests running on Python 3.13. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
tests/playwright/shiny/components/table/app.py:6
- The current version check will raise a RuntimeError for any Python version 3.13 or above, which may be unintended if future versions are supported. Consider changing the condition to 'if sys.version_info[:2] != (3, 13)' or a similar check to target only Python 3.13.
if sys.version_info < (3, 13):
Currently the tests for
test_data_frame_data_type
fail becausemodin
cannot be installed in python3.13
version.So we skip the tests till the support for modin on 3.13 is resolved.