Better messages for AttributeError
in Shiny Express
#888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #869.
Previously in the case of an
AttributeError
, it would print this:With this PR, it will print a normal stack trace and then a
RuntimeError
:This PR wraps the bulk of the
run_express
function in atry
statement. I also added a bit of code to preserve the previoussys.displayhook
, and then restore it in thefinally
. This is helpful when running multiple concurrent apps, to ensure thatsys.displayhook
isn't left in an intermediate state.To see the actual substantive changes (and not just indentation change), turn on "Hide whitespace".