Skip to content

Makefile and Dockerfile template updates #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 12, 2020

Conversation

phillipross
Copy link
Contributor

  • Updated dockerfile templates to reflect new maintainer labeling, debian package
    installation, and alpine build process
  • Updated Makefile to change mdillon docker repo to postgis docker repo
  • Updated update.sh script to use more modern parsing of debian packages to
    accommodate multiple debian versions in a similar way to how the postgres image
    built as part of docker-library accomplishes it

…bian package installation,

  and alpine build process
- Updated Makefile and postgis-config.sh for tests to change mdillon docker repo to
  postgis docker repo
- Updated update.sh script to use more modern parsing of debian packages to accommodate multiple
  debian versions in a similar way to how the postgres image built as part of docker-library
  accomplishes it
@phillipross phillipross force-pushed the makefile-and-template-update branch from ea5f505 to 62d2c57 Compare February 10, 2020 04:11
@phillipross phillipross marked this pull request as ready for review February 10, 2020 04:24
@smellman smellman mentioned this pull request Feb 10, 2020
…1, and 12 (dropping EOL 9.4)

- Added Dockerfile template processing for debian images
@smellman
Copy link
Contributor

smellman commented Feb 11, 2020

@phillipross I recommend to add travis_retry command.
see: 5345e73
In my case travis ci failed in using wget command in alpine build.
https://travis-ci.org/postgis/docker-postgis/jobs/646651624

@phillipross
Copy link
Contributor Author

@smellman Thanks for the suggestion. The way you had it configured, I think it would retry building the docker image if it fails for any reason, not just a network timeout, true? I have a feeling that this might be too broad and such fault tolerance should probably be handled in the Dockerfile itself when it's pulling external dependencies.

…s in an associate array

  since version 3.0.0 package only contains the major version and not the minor
- Changes to Makefile to use tags formed from the version-specific directory names
- Added overridable variables to Makefile to enable passing in repository and image name
  from environment variables
- Added version-specific directory to create a build for postgres v9.5.x w/ 3.0.x
@phillipross phillipross merged commit 79fcb41 into postgis:master Feb 12, 2020
@phillipross phillipross deleted the makefile-and-template-update branch February 13, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants