Remove erroneous cast to size_t in BID_HASH_FUNC #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ololobus
suggested changes
May 24, 2021
| @@ -86,7 +86,7 @@ typedef PtrackMapHdr * PtrackMap; | |||
| /* Block address 'bid' to hash. To get slot position in map should be divided | |||
| * with '% PtrackContentNblocks' */ | |||
| #define BID_HASH_FUNC(bid) \ | |||
| (size_t)(DatumGetUInt64(hash_any_extended((unsigned char *)&bid, sizeof(bid), 0))) | |||
| (DatumGetUInt64(hash_any_extended((unsigned char *)&bid, sizeof(bid), 0))) | |||
There was a problem hiding this comment.
Yeah, this size_t seems to be not correct, since it is 32 bit wide on 32 bit systems, which is not what we want here. However, next we assign this value to hash variable, which again has a size_t type, so this change alone does not has much sense, doesn't it? Probably we should change all appearances of size_t used for hash map reference to uint64 for portability?
There was a problem hiding this comment.
Yep, I recognize hash variable as well. I've just push-forced branch.
It were mistakenly remain after change of BID_HASH_FUNC meaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It were mistakenly remain after change of BID_HASH_FUNC meaning