You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In 1.8.2 cleanup() method always removed data directory, 1.8.3 removes data directory only in case of custom base path:
- # choose directory to be removed
- if testgres_config.node_cleanup_full:
- rm_dir = self.base_dir # everything
- else:
- rm_dir = self.data_dir # just data, save logs
+ # only remove if base directory was temporary
+ if not self._custom_base_dir:
+ # choose directory to be removed
+ if testgres_config.node_cleanup_full:
+ rm_dir = self.base_dir # everything
+ else:
+ rm_dir = self.data_dir # just data, save logs
- rmtree(rm_dir, ignore_errors=True)
+ rmtree(rm_dir, ignore_errors=True)
The text was updated successfully, but these errors were encountered:
Per perort in [issue #57]: cleanup backward compatibility broken in 1.8.3.
If this feature is needed, feel free to bring it back, but maintain compatibility.
This reverts commit cdc933f.
In 1.8.2 cleanup() method always removed data directory, 1.8.3 removes data directory only in case of custom base path:
The text was updated successfully, but these errors were encountered: