Skip to content

cleanup backward compatibility broken in 1.8.3 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gsmolk opened this issue Oct 19, 2020 · 1 comment
Closed

cleanup backward compatibility broken in 1.8.3 #57

gsmolk opened this issue Oct 19, 2020 · 1 comment
Labels

Comments

@gsmolk
Copy link
Contributor

gsmolk commented Oct 19, 2020

In 1.8.2 cleanup() method always removed data directory, 1.8.3 removes data directory only in case of custom base path:

-        # choose directory to be removed
-        if testgres_config.node_cleanup_full:
-            rm_dir = self.base_dir    # everything
-        else:
-            rm_dir = self.data_dir    # just data, save logs
+        # only remove if base directory was temporary
+        if not self._custom_base_dir:
+            # choose directory to be removed
+            if testgres_config.node_cleanup_full:
+                rm_dir = self.base_dir    # everything
+            else:
+                rm_dir = self.data_dir    # just data, save logs
 
-        rmtree(rm_dir, ignore_errors=True)
+            rmtree(rm_dir, ignore_errors=True)
@gsmolk gsmolk added the bug label Oct 19, 2020
alubennikova added a commit that referenced this issue Oct 20, 2020
Per perort in [issue #57]: cleanup backward compatibility broken in 1.8.3.
If this feature is needed, feel free to bring it back, but maintain compatibility.

This reverts commit cdc933f.
@arssher
Copy link
Contributor

arssher commented Oct 21, 2020

done in a3f6dd3

@arssher arssher closed this as completed Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants