adding key -F to pg_dump #32
Conversation
|
You should fix code style for this pull request. Major problems from pep8 checker but also will be good if you remove comments lines. |
|
Tests should be based on unittest library. |
testgres/node.py
Outdated
| @@ -583,8 +583,8 @@ def cleanup(self, max_attempts=3): | |||
| def psql(self, | |||
| dbname, | |||
| query=None, | |||
| filename=None, | |||
There was a problem hiding this comment.
Arguments should not be moved around.
testgres/node.py
Outdated
| @@ -658,7 +658,7 @@ def safe_psql(self, dbname, query, username=None, input=None): | |||
|
|
|||
| return out | |||
|
|
|||
| def dump(self, dbname, username=None, filename=None): | |||
| def dump(self, dbname, username=None, filename=None, formate=None): | |||
There was a problem hiding this comment.
Probably should replace formate with format (I know, it's a function name, but who cares).
testgres/node.py
Outdated
|
|
||
| Returns: | ||
| Path to a file containing dump. | ||
| """ | ||
|
|
||
| # Set default arguments | ||
| username = username or _default_username() | ||
| formate = formate or "p" |
There was a problem hiding this comment.
"p" should be replaced with a const defined in consts.py
tests/test_pgdump.py
Outdated
| # 1) make dump to new place | ||
| # pg_dump mydb > db.sql | ||
| # 2) make dump to non default formate | ||
| # 2.5) Чтобы сформировать выгрузку в формате plain: |
There was a problem hiding this comment.
Russian comments is a big no-no.
|
I think we should drop this PR. |
|
@stalkerg I believe we should give @Fenimorkin a chance to finish his work. |
|
Can you ask him directly? Maybe he has no plans to finish that. |
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 97.17% 97.01% -0.17%
==========================================
Files 16 16
Lines 1381 1405 +24
==========================================
+ Hits 1342 1363 +21
- Misses 39 42 +3
Continue to review full report at Codecov.
|
Added key unnecessary formate for dump()
-F format
--format=format
Selects the format of the output. format can be one of the following:
p
plain
Output a plain-text SQL script file (the default).
c
custom
Output a custom-format archive suitable for input into pg_restore. Together with the directory output format, this is the most flexible output format in that it allows manual selection and reordering of archived items during restore. This format is also compressed by default.
d
directory