Add promote() method #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 97.12% 97.15% +0.03%
==========================================
Files 17 17
Lines 1529 1547 +18
==========================================
+ Hits 1485 1503 +18
Misses 44 44
Continue to review full report at Codecov.
|
funbringer
requested changes
Jun 4, 2018
testgres/node.py
Outdated
| # for versions below 10 `promote` is asynchronous so we need to wait | ||
| # until it actually becomes writable | ||
| if self._pg_version < '10': | ||
| check_query = "SHOW transaction_read_only" |
There was a problem hiding this comment.
This is not safe since transactions might be read-only by default.
| @@ -683,14 +683,50 @@ def reload(self, params=[]): | |||
| _params = [ | |||
| get_bin_path("pg_ctl"), | |||
| "-D", self.data_dir, | |||
| "-w", # wait | |||
…UC variable in promote() func
|
LGTM, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing promote() method which corresponds to pg_ctl's
promotemode.