Skip to content

add 'suppress' to PostgresNode.poll_query_until() to mute exceptions #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

funbringer
Copy link
Collaborator

This is an alternative approach to the problem covered by PR #50.

The idea is to provide a set of suppressed exceptions to poll_query_until.

@funbringer funbringer requested a review from gsmolk July 11, 2018 10:34
@funbringer
Copy link
Collaborator Author

@gsmol please, take a look at this one.

@codecov-io
Copy link

codecov-io commented Jul 11, 2018

Codecov Report

Merging #51 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   97.18%   97.31%   +0.12%     
==========================================
  Files          17       17              
  Lines        1564     1562       -2     
==========================================
  Hits         1520     1520              
+ Misses         44       42       -2
Impacted Files Coverage Δ
tests/test_simple.py 99.81% <ø> (ø) ⬆️
testgres/__init__.py 100% <ø> (ø) ⬆️
testgres/connection.py 95.23% <100%> (+0.15%) ⬆️
testgres/node.py 97.53% <100%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c187ccb...e78ddd9. Read the comment docs.

@funbringer funbringer merged commit 0847cf2 into postgrespro:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants