Add CRC64-NVMe #45
Merged
Add CRC64-NVMe #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
Contributor
Author
|
I would like to include in rails/rails#54123 |
postmodern
requested changes
Jan 24, 2025
Owner
postmodern
left a comment
postmodern
left a comment
There was a problem hiding this comment.
Looks good, manually code spacing issues. Probably need to add an .editorconfig file.
Contributor
Author
|
Thanks for the review, issues should be resolved. |
postmodern
approved these changes
Jan 24, 2025
Owner
|
Merged into the 0.7.0 branch. Should be released soon, just need to update the ChangeLog. |
Owner
|
0.7.0 has now been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for CRC64-NVMe based on https://reveng.sourceforge.io/crc-catalogue/all.htm#crc.cat.crc-64-nvme
This is the current algorithm recommended by Amazon S3 object integrity checking.