Skip to content

Update Beatmap info user tag style #12115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

notbakaneko
Copy link
Collaborator

@notbakaneko notbakaneko commented Apr 16, 2025

Displays it more like the game client
image

Some tags are kind of long and don't really fit in the existing box, though:
image

Now with page theme colours instead:
image
image

h1 colour if user voted for that tag
image

I don't know what to do with the on-hover colours since multi-colour background buttons were never a thing on web before 👀

@nanaya
Copy link
Collaborator

nanaya commented Apr 16, 2025

where did these colors come from...

@Hiviexd
Copy link
Member

Hiviexd commented Apr 16, 2025

would be nice if the colors used the page's hue.

also, thoughts on truncating the text in long tags so they fit in one line? can reveal the full contents of said tags on a hover tooltip.

@bdach
Copy link
Contributor

bdach commented Apr 16, 2025

where did these colors come from...

My ass, quite frankly. The entire results screen in client is a mess of bleh grays. I was just attempting to put something in there that doesn't stick out like a sore thumb.

Maybe you can get @arflyte to find better ones? 🤷

@nanaya
Copy link
Collaborator

nanaya commented Apr 16, 2025

also it's kinda long with pretty much just one tag per "line"

@bdach
Copy link
Contributor

bdach commented Apr 16, 2025

The place where this design is used in client (results screen) has much more width to work with 🤷

Me just a grug programmer I ship feature I cannot into good UX design.

@notbakaneko
Copy link
Collaborator Author

The entire space for beatmap metadata is kind of narrow, even on the tentative-not-quite-new-anymore design, everything is crammed into too narrow columns...

@notbakaneko notbakaneko force-pushed the feature/beatmap-info-new-user-tag-display branch from 86b557d to 5b761a9 Compare May 22, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Next up
Development

Successfully merging this pull request may close these issues.

4 participants