Allow pulling active matches in /matches endpoint #12418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11636
Gives the option for users to get active rooms via active query by checking if the
end_time
is null. When active query is false, it does the same default behavior of returning active & unactive rooms like when normally getting /matches. It wasn't really clear in the issue if whenactive=false
, it should show inactive rooms, so I just made it have the same behavior of showing active & unactive matches.Do I need to add or do anything for this page also?
link: https://osu.ppy.sh/docs/index.html#matches
endpoint examples:
api examples