Skip to content

Conversation

someonecantcode
Copy link
Contributor

@someonecantcode someonecantcode commented Sep 23, 2025

Closes #11636

Gives the option for users to get active rooms via active query by checking if the end_time is null. When active query is false, it does the same default behavior of returning active & unactive rooms like when normally getting /matches. It wasn't really clear in the issue if when active=false, it should show inactive rooms, so I just made it have the same behavior of showing active & unactive matches.

Do I need to add or do anything for this page also?
link: https://osu.ppy.sh/docs/index.html#matches

endpoint examples:

/matches?active=1  
/matches?active=true

api examples

teawsl@egghead:~/osu-web$ curl -H "Authorization: Bearer $TOKEN"   \ --get http://localhost:8080/api/v2/matches
{
  "matches": [
    {
      "id": 2,
      "start_time": "2025-09-23T00:52:33+00:00",
      "end_time": "2025-09-23T01:47:33+00:00",
      "name": "inactive 1"
    },
    {
      "id": 1,
      "start_time": "2025-09-23T01:42:33+00:00",
      "end_time": null,
      "name": "active 1"
    }
  ],
  "params": {
    "limit": 50,
    "sort": "id_desc",
    "active": null
  },
  "cursor": null,
  "cursor_string": null
}

teawsl@egghead:~/osu-web$ curl -H "Authorization: Bearer $TOKEN"  \ --get  http://localhost:8080/api/v2/matches?active=1
{
  "matches": [
    {
      "id": 1,
      "start_time": "2025-09-23T01:42:33+00:00",
      "end_time": null,
      "name": "active 1"
    }
  ],
  "params": {
    "limit": 50,
    "sort": "id_desc",
    "active": true
  },
  "cursor": null,
  "cursor_string": null
}

someonecantcode and others added 3 commits September 22, 2025 19:26
Extend signature editor size

Fill up the entire section width as nothing else is using the specified
width and it can use the extra width.

phpcs whitespace linting fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow pulling only open multiplayer lobbies from /matches endpoint
2 participants