Skip to content

Simplify approach rate formulas.md #13142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

Simplify approach rate formulas.md #13142

merged 5 commits into from
Jul 15, 2025

Conversation

Esnos33
Copy link
Contributor

@Esnos33 Esnos33 commented Apr 14, 2025

Formulas in approach rate can be simplified by using equivalent transformations to much easier to understand form.

Self-check

Formulas in approach rate can be simplified by using equivalent transformations to much easier to understand form.
Copy link
Contributor

Thank you for contributing to the osu! wiki.

Please take note of the following:

  • Make sure you've read this self-check checklist.

  • Translations that have not been reviewed by a native speaker will be merged after a minimum of 1 week. If there are no reviewers for your language, please mention it explicitly.

  • Refrain from spamming the Update branch button. A maintainer will do this before merging anyway.

  • Apply review suggestions in batches from the Files changed tab like this:

    Demo GIF

See the contribution guide for more information.

All changes are run through continuous integration checks, which provide automatic detection of common errors. If you need help with decrypting CI check error messages, or with any other issues, ask in the #osu-wiki channel on the osu! Discord server.

@peppy
Copy link
Member

peppy commented Apr 16, 2025

I dunno, this doesn't do much for me.

@Esnos33
Copy link
Contributor Author

Esnos33 commented Apr 16, 2025

Instead of two tables there is only one table, formulas are easier to calculate in mind and it is clear when hitcircles fade in to 100%, I thought this is better.

@peppy
Copy link
Member

peppy commented Apr 17, 2025

I'm open to other opinions, but this differs from how we've always written this internally. I personally prefer not having constants change per instance.

@TicClick
Copy link
Contributor

I agree with the fade-out edit, but would like to keep initial formulas as well -- while becoming easier to calculate, they partially lose the expressiveness

@Esnos33
Copy link
Contributor Author

Esnos33 commented Apr 17, 2025

If you like formulas, then maybe I can simplify formulas like this?

1200ms + 600ms * (5 - AR) / 5 -> 1200ms + 120ms * (5 - AR)
1200ms - 750ms * (AR - 5) / 5 -> 1200ms - 150ms * (AR - 5)

I really don't know why you need / 5

@TicClick
Copy link
Contributor

@peppy would that be fine by you?

@peppy peppy enabled auto-merge (squash) July 15, 2025 07:08
@peppy peppy merged commit 0cba10a into ppy:master Jul 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants