Fix replays not correctly pre-importing beatmap when arriving from a cold start #31508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…als are present Currently, there's a period where the API is `Offline` even though it is about to connect (as soon as the `run` thread starts up). This can cause any `Queue`d requests to fail if they arrive too early. To avoid this, let's ensure the `Connecting` state is set as early as possible.
peppy
added
the
area:online functionality
peppy
changed the title
Connecting immediately on startup when credentials are present
peppy
changed the title
peppy
commented
Jan 14, 2025
smoogipoo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, if you double-clicked a replay while lazer wasn't open, if the beatmap isn't already locally available it would just show a fail message rather than attempting to download the beatmap for you.
LocalUserin correct state #31507 for mergeabilityCurrently, there's a period where the API is
Offlineeven though it is about to connect (as soon as therunthread starts up).This can cause any
Queued requests to fail if they arrive too early. To avoid this, let's ensure theConnectingstate is set as early as possible.Closes #31489.
I'm sure we want test coverage of this, but it's a pretty high bar since async and no existing tests of
APIAccess.