Add "Alternate" mod to osu!taiko #33518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Are you still interested in this PR? If so, there are a couple minor changes I'd like to propose, and getting this up to date would be nice because I'm interested in a mod like this getting in since the singletap and alternate mods have been ranked in standard and taiko already. If you aren't interested anymore I'm perfectly willing to take over this branch. |
Member
|
@Natelytle yes, there still seems to be interest to please bring this up-to-date and we'll give it another shot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an "Alternate" mod similar to the osu ruleset and complements taiko's singletap mod.
I've seen the old PR, I'm not exactly sure what code quality concerns there were there but I tried to make this cleaner.
Also,
osu.Game.Rulesets.Osu.Mods.InputBlockingModand the newosu.Game.Rulesets.Taiko.Mods.InputBlockingModclasses are very similar, I believe they could lifted up toosu.Game.Rulesets.Modseasily. I didn't wanna touch osu ruleset and engine code unnecessarily, but if it's ok I can add it to this PR.