Skip to content

Fix play button starting wrong beatmap before selection loads #36104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
itsdaliia wants to merge 3 commits into
base: master
Choose a base branch
from
+47 −0
Open

Fix play button starting wrong beatmap before selection loads #36104

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
766334a
Fix play button starting wrong beatmap before selection loads
itsdaliia Dec 22, 2025
fad5d08
Use ensureGlobalBeatmapValid() for logo and Enter key actions
itsdaliia Dec 23, 2025
6acf288
Add test for beatmap selection timing bug
itsdaliia Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion osu.Game/Screens/SelectV2/SongSelect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,9 @@ protected override void LogoArriving(OsuLogo logo, bool resuming)

logo.Action = () =>
{
SelectAndRun(Beatmap.Value.BeatmapInfo, OnStart);
// use carousel's current selection instead of global beatmap to avoid debounce issues
var beatmapToPlay = carousel.CurrentGroupedBeatmap?.Beatmap ?? Beatmap.Value.BeatmapInfo;
SelectAndRun(beatmapToPlay, OnStart);
return false;
};
}
Expand Down