Add "Background fill mode" setting #36111
Conversation
|
Reminder that this setting should also be in First run setup as well. |
| fillMode = config.GetBindable<BackgroundFillMode>(OsuSetting.BackgroundFillMode); | ||
| fillMode.BindValueChanged(_ => loadBeatmapBackground(beatmap)); |
There was a problem hiding this comment.
Why is this change handling done here as opposed to inside BeatmapBackground?
Also, we never put BindValueChanged inside BDL methods as it is thread unsafe.
There was a problem hiding this comment.
it's really strange, don't remember why i did this, maybe something didn't work before that
should i use BindValueChanged inside LoadComplete instead?
There was a problem hiding this comment.
Yes, but also consider not reloading the whole beatmap to update the mode. I think the can be removed and handled exclusively in BeatmapBackground.
| { | ||
| base.LoadComplete(); | ||
|
|
||
| fillMode.ValueChanged += _ => updateBackgroundFillMode(); |
There was a problem hiding this comment.
now, BindValueChanged doesn't seem to work properly during and after playing beatmap
@peppy what could be the reason for this?
2025-12-26.13-53-45.mp4
3 participants
a slightly better version with localisation and code quality