Skip to content

Select should have a value prop #1286

Open

Description

@photz

In plain Preact you can choose which option of a select element should be selected like this:

<select value="2">
  <option value="1">Foo</option>
  <option value="2">Bar</option>
</select>

Unless I've missed something, then the Select component in this package only lets you set the selected option by either setting the selectedIndex prop of Select itself or using the selected prop of Select.Item.

I think it would make sense to let Select behave like a regular select in this regard, what do you think?

Activity

  1. cromefire commented on Feb 23, 2019

    @cromefire
    Collaborator

    If I'm correct, this is a current limitation by mdc or does this work with plain html?

  2. prateekbh commented on Feb 24, 2019

    @prateekbh
    Owner

    Currently selectedIndex prop is an equivalent to value prop

  3. cromefire commented on Feb 24, 2019

    @cromefire
    Collaborator

    Well selectedIndex takes an index not a value

  4. prateekbh commented on Feb 24, 2019

    @prateekbh
    Owner

    ah gotcha... sorry was attention was divided back then

    Lets keep this for 2.0?

  5. added this to the 2.0 milestone on Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions