Skip to content

Commit 0cfee78

Browse files
authored
refactor: Conditionally copying sw & template to new projects (#1508)
* refactor: Conditionally copying resources to template dirs * refactor: Removed concept of "demo" from widgets so sw doesn't have much of a point there * docs: Adding changeset
1 parent 66aa783 commit 0cfee78

File tree

2 files changed

+21
-11
lines changed

2 files changed

+21
-11
lines changed

.changeset/healthy-toys-heal.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'preact-cli': patch
3+
---
4+
5+
On project create, the CLI won't copy the HTML template or the service worker when the source template is a widget

packages/cli/lib/commands/create.js

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -383,18 +383,23 @@ async function command(repo, dest, argv) {
383383

384384
const sourceDirectory = join(resolve(cwd, dest), 'src');
385385

386-
// Copy over template.html
387-
const templateSrc = resolve(
388-
__dirname,
389-
join('..', 'resources', 'template.html')
390-
);
391-
const templateDest = join(sourceDirectory, 'template.html');
392-
await copyFileToDestination(templateSrc, templateDest);
386+
if (!repo.includes('widget')) {
387+
// Copy over template.html
388+
const templateSrc = resolve(
389+
__dirname,
390+
join('..', 'resources', 'template.html')
391+
);
392+
const templateDest = join(sourceDirectory, 'template.html');
393+
await copyFileToDestination(templateSrc, templateDest);
393394

394-
// Copy over sw.js
395-
const serviceWorkerSrc = resolve(__dirname, join('..', '..', 'sw', 'sw.js'));
396-
const serviceWorkerDest = join(sourceDirectory, 'sw.js');
397-
await copyFileToDestination(serviceWorkerSrc, serviceWorkerDest);
395+
// Copy over sw.js
396+
const serviceWorkerSrc = resolve(
397+
__dirname,
398+
join('..', '..', 'sw', 'sw.js')
399+
);
400+
const serviceWorkerDest = join(sourceDirectory, 'sw.js');
401+
await copyFileToDestination(serviceWorkerSrc, serviceWorkerDest);
402+
}
398403

399404
if (argv.install) {
400405
spinner.text = 'Installing dependencies:\n';

0 commit comments

Comments
 (0)