refactor: Conditionally copying resources to template dirs #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7a41b3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
refactor/resourceCopying
branch
from
df9d7b8 to
1580cb4
Compare
rschristian
force-pushed
the
refactor/resourceCopying
branch
from
12d9b99 to
11519aa
Compare
ForsakenHarmony
approved these changes
Nov 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
No
Summary
The issue is that there are two templates not like the others: the widgets. These two do not need
template.htmlorsw.jscopied over to them.Does this PR introduce a breaking change?
No
Other information
One thing I'm not entirely sure of is adding this behavior by checking for "widget" in the repo name. Should this instead look to check the exact repo name so that a user who has "widget" in their repo title doesn't enable this behavior?
Edit: Waiting on preactjs-templates/widget-typescript#4, as it too would be affected