Skip to content

refactor: Conditionally copying resources to template dirs #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rschristian merged 5 commits into from
Nov 13, 2021
Merged

refactor: Conditionally copying resources to template dirs #1508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1580cb4
refactor: Conditionally copying resources to template dirs
rschristian Dec 28, 2020
4991eb1
refactor: Removed concept of "demo" from widgets so sw doesn't have m…
rschristian Jan 8, 2021
2c3090e
docs: Adding changeset
rschristian Jan 13, 2021
11519aa
Merge branch 'master' into refactor/resourceCopying
rschristian May 12, 2021
7a41b3d
Merge branch 'master' into refactor/resourceCopying
rschristian Nov 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-toys-heal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-cli': patch
---

On project create, the CLI won't copy the HTML template or the service worker when the source template is a widget
27 changes: 16 additions & 11 deletions packages/cli/lib/commands/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,18 +383,23 @@ async function command(repo, dest, argv) {

const sourceDirectory = join(resolve(cwd, dest), 'src');

// Copy over template.html
const templateSrc = resolve(
__dirname,
join('..', 'resources', 'template.html')
);
const templateDest = join(sourceDirectory, 'template.html');
await copyFileToDestination(templateSrc, templateDest);
if (!repo.includes('widget')) {
// Copy over template.html
const templateSrc = resolve(
__dirname,
join('..', 'resources', 'template.html')
);
const templateDest = join(sourceDirectory, 'template.html');
await copyFileToDestination(templateSrc, templateDest);

// Copy over sw.js
const serviceWorkerSrc = resolve(__dirname, join('..', '..', 'sw', 'sw.js'));
const serviceWorkerDest = join(sourceDirectory, 'sw.js');
await copyFileToDestination(serviceWorkerSrc, serviceWorkerDest);
// Copy over sw.js
const serviceWorkerSrc = resolve(
__dirname,
join('..', '..', 'sw', 'sw.js')
);
const serviceWorkerDest = join(sourceDirectory, 'sw.js');
await copyFileToDestination(serviceWorkerSrc, serviceWorkerDest);
}

if (argv.install) {
spinner.text = 'Installing dependencies:\n';
Expand Down