Skip to content

Commit c9c48db

Browse files
authored
refactor: Replacing mkdirp with native mkdir recursive (#1504)
1 parent 977d59a commit c9c48db

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

.changeset/loud-monkeys-compete.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'preact-cli': patch
3+
---
4+
5+
Replacing mkdirp with native mkdir recursive

packages/cli/lib/commands/create.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ const { promisify } = require('util');
33
const fetch = require('isomorphic-unfetch');
44
const glob = promisify(require('glob').glob);
55
const gittar = require('gittar');
6-
const mkdirp = require('mkdirp');
76
const fs = require('../fs');
87
const os = require('os');
98
const { green } = require('kleur');
@@ -271,7 +270,7 @@ async function command(repo, dest, argv) {
271270
}
272271

273272
if (!fs.existsSync(resolve(cwd, dest, 'src'))) {
274-
mkdirp.sync(resolve(cwd, dest, 'src'));
273+
fs.mkdirSync(resolve(cwd, dest, 'src'), { recursive: true });
275274
}
276275

277276
// Attempt to fetch the `template`

packages/cli/lib/fs.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
const {
22
mkdir,
3+
mkdirSync,
34
readFile,
45
writeFile,
56
copyFile,
@@ -11,6 +12,7 @@ const { promisify } = require('util');
1112

1213
module.exports = {
1314
mkdir: promisify(mkdir),
15+
mkdirSync,
1416
copyFile: promisify(copyFile),
1517
readFile: promisify(readFile),
1618
writeFile: promisify(writeFile),

packages/cli/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
"devDependencies": {
4848
"html-looks-like": "^1.0.2",
4949
"jest": "^26.0.1",
50-
"mkdirp": "^1.0.3",
5150
"ncp": "^2.0.0",
5251
"node-sass": "^4.12.0",
5352
"p-retry": "^4.1.0",

packages/cli/tests/lib/cli.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
const { join } = require('path');
2-
const { existsSync, unlinkSync, symlinkSync } = require('fs');
2+
const { existsSync, mkdirSync, unlinkSync, symlinkSync } = require('fs');
33
const cmd = require('../../lib/commands');
44
const { tmpDir } = require('./output');
5-
const mkdirp = require('mkdirp');
65
const shell = require('shelljs');
76

87
const root = join(__dirname, '../../../..');
@@ -37,7 +36,7 @@ exports.create = async function (template, name) {
3736

3837
exports.build = function (cwd, options, installNodeModules = false) {
3938
if (!installNodeModules) {
40-
mkdirp.sync(join(cwd, 'node_modules')); // ensure exists, avoid exit()
39+
mkdirSync(join(cwd, 'node_modules'), { recursive: true }); // ensure exists, avoid exit()
4140
linkPackage('preact', root, cwd);
4241
linkPackage('preact-render-to-string', root, cwd);
4342
} else {

0 commit comments

Comments
 (0)