preact watch --https=true, runs http instead of https if cert has been created.

[flea89]

I've tried to run the devserver on https, If the webpack certificate is used the server starts an https server as expected.

If a certificate has been created ( the webpack one isn't used) the server starts over http instead of https.

I've had a quick look to the source code, and I think the issue is https://github.com/developit/preact-cli/blob/2bd02cb8e5c442c0987d90d6cada3a91516fa790/src/lib/webpack/webpack-client-config.js#L126, ssl is an object and not a boolean.

If I'm not wrong that object is set https://github.com/developit/preact-cli/blob/master/src/commands/watch.js#L47.

Thanks

[developit]

The flag is preact watch --https - it seems like passing =true is killing that conditional. Can you test without the value?

[flea89]

Unfortunately that doesn't solved the problem.
Https option is actually picked but doesn't starts an https server in that case ( it does with the same command if webpack cert is used).

Isn't the problem that getSsl returns an object and webpack-client-config tests for a boolean true ?

[developit]

hmm yeah - not sure where that was introduced. the boolean check should just be removed, WebpackDevServer allows an object or boolean for that property. If you have a chance to open a PR that would be awesome!

[flea89]

Nice I was just sending the pull request but I this has been already fixed.
Good job!

[reznord]

Closing this issue, fixed in #176