HMR not working in 2.0.0

[selrond]

Do you want to request a feature or report a bug?
bug

What is the current behavior?
If I change something (component content for example) in my code, I have to do a manual page reload, seems like HMR has stopped working or something

If the current behavior is a bug, please provide the steps to reproduce.
Try to change something and see if it refreshes in the browser automatically

What is the expected behavior?
The changes are reflected immediately

Please mention other relevant information.

• node version: 8.7.0
• npm version: 5.5.1
• Operating system MacOS 10.12.6 (16G29)

[lukeed]

Hey,

I've spun up a fresh 2.0 app with the default template. HMR very much works.

Do you have a preact.config.js? Something there might be affecting the setup.

[selrond]

@lukeed I don't. I've used it out of the box, and suddenly - after I updated to v2.0.0, it's stopped working.

[lukeed]

I'd wipe everything. Remove node_modules and any lock files, then reinstall.

[selrond]

@lukeed done that. Nothing.

[selrond]

@lukeed possibly related? Hot Reloading broke - webpack v3 · Issue #949 · webpack/webpack-dev-server

[lukeed]

Update: I was testing a 1.4.1 app, 🤦‍♂️

Webpack 3.x is indeed not allowing HMR. I've tested removal of ModuleConcatenationPlugin and it had no effect, which I expected, since we're only using it in production builds.

[reznord]

I just checked with v2.0.0 on a new machine. It works totally fine for me. All the changes what I make in the code are being reflected in the browser as usual.

[lukeed]

@reznord https://github.com/preactjs-templates/default/blob/master/template/package.json#L21

[selrond]

@reznord are you sure you're working with 2.0.0? Check your package.json

[reznord]

Ah, bummer! My bad. So, HRM does fail in latest version. 😞

[selrond]

@developit Anything we can do about that?

[rchaubey]

removing ModuleConcatenationPlugin from webpack.base.config doesn't solve it. Changing the version to 1.4.1 it works.

[selrond]

@rchaubey yep - exactly what @lukeed tried

[reznord]

@rchaubey changing to 1.4.1 works because we are on webpack 2.x in v1.4.1 in which the HMR works without any problem.