Prerender fails when using React component

[thangngoc89]

This is yet another SSR bug :D

Reproduce:

• Include any 3rd party component and run build with prerender
• Error message:

Template execution failed: Error: Cannot find module 'react'
  Error: Cannot find module 'react'
  
  - prerender.js:43 Function.Module._resolveFilename
    [frontend]/[preact-cli]/lib/lib/prerender.js:43:21
  
  - module.js:20 require
    internal/module.js:20:19
  
  - index.jsx:1 Object.<anonymous>
    /home/khoa/web/tooth/frontend/components/Search/index.jsx:1:1
  
  - node.js:144 loader
    [frontend]/[babel-register]/lib/node.js:144:5
  
  - node.js:154 Object.require.extensions.(anonymous function) [as .jsx]
    [frontend]/[babel-register]/lib/node.js:154:7
  
  - module.js:20 require
    internal/module.js:20:19
  
  - index.js:7 Object.<anonymous>
    /home/khoa/web/tooth/frontend/index.js:7:1
  
  - node.js:144 loader
    [frontend]/[babel-register]/lib/node.js:144:5
  
  - node.js:154 Object.require.extensions.(anonymous function) [as .js]
    [frontend]/[babel-register]/lib/node.js:154:7

[developit]

Ah weird, module-alias was actually never set up. We need to add it to prerender.js. That might actually be the root of some of the other issues.

[kurtextrem]

couldn't a webpack build be used for the prerender? That way webpack's alias could be used and code functionality wouldn't somewhat get duplicated.

[developit]

Yes. Looks like @rkostrzewski is working on it because he's a genius.

[kurtextrem]

Awesome! LMK if you need / want help.

(and just for the overview - maybe add the SSR label to this issue and to the PR?)

[jangerhofer]

@developit: Do I understand correctly that the module-alias redirects react and react-dom includes to the corresponding preact packages, as described in the preact-compat config?

I'm wondering because I'd like to use preact (and the convenience of the CLI!) with React packages, but preact-compat requires access to the webpack.config.

[developit]

Label added :)

@jangerhofer yes, that's what module-alias would be doing for us. Webpack is already doing it for our browser build, but we are currently doing server rendering straight in Node. Once we move the SSR to using Webpack, the aliases will be handled the same as they are in the browser.

[asci]

is there any workaround? --prerender false is not helping :(

[rkostrzewski]

@asci have you tried --no-prerender? If I recall correctly that's how to that with yargs

[asci]

@rkostrzewski oh, thanks. looks like it helps