Skip to content

Refactor: Remove 'sw-debug.js' from prod output #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prateekbh merged 4 commits into from
Dec 2, 2020
Merged

Refactor: Remove 'sw-debug.js' from prod output #1478

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aec21db
refactor: sw-debug is now no longer copied to prod builds
rschristian Dec 2, 2020
98bd689
docs: Adding changeset
rschristian Dec 2, 2020
d0449ce
test: Updating test suite to not expect sw-debug in prod
rschristian Dec 2, 2020
3804d07
revert: Code style change
rschristian Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-ants-deny.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-cli': patch
---

No longer copies 'sw-debug.js' to output directory on prod builds. No functional changes, as it was not used.
12 changes: 4 additions & 8 deletions packages/cli/lib/lib/webpack/webpack-client-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ async function clientConfig(env) {
// copy any static files
existsSync(source('assets')) && { from: 'assets', to: 'assets' },
// copy sw-debug
{
!isProd && {
from: resolve(__dirname, '../../resources/sw-debug.js'),
to: 'sw-debug.js',
},
Expand Down Expand Up @@ -120,13 +120,9 @@ function getBabelEsmPlugin(config) {
beforeStartExecution: (plugins, newConfig) => {
const babelPlugins = newConfig.plugins;
newConfig.plugins = babelPlugins.filter(plugin => {
if (
Array.isArray(plugin) &&
plugin[0].indexOf('fast-async') !== -1
) {
return false;
}
return true;
return !(
Array.isArray(plugin) && plugin[0].indexOf('fast-async') !== -1
);
});
plugins.forEach(plugin => {
if (
Expand Down