Skip to content

upgrade to webpack3 and add scope hoisting #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hassanbazzi wants to merge 17 commits into from
Closed

upgrade to webpack3 and add scope hoisting #150

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7ea05ba
upgrade to webpack3 and add scope hoisting
hassanbazzi Jun 28, 2017
87550af
remove old loaders and import correct webpack
hassanbazzi Jun 29, 2017
975ee67
bring back loaders
hassanbazzi Jun 29, 2017
cb34094
conflicts
hassanbazzi Jun 29, 2017
6179771
install uglify-js & uglifyjs-webpack-plugin
lukeed Jul 6, 2017
5555bc4
Revert; misunderstood webpack3 docs
lukeed Jul 6, 2017
cbffd6e
Merge branch 'master' into feature/webpack3
developit Jul 16, 2017
ab03e7b
Merge branch 'master' into feature/webpack3
rkostrzewski Jul 22, 2017
18bd9ec
Remove webpack-blocks in favor of webpack-merge
rkostrzewski Jul 23, 2017
79fb4fa
Add extract-text-webpack-plugin to deps, upgrade webpack deps
rkostrzewski Jul 23, 2017
421634c
Add missing dependencies, replace postcss-loader options
rkostrzewski Jul 23, 2017
8ca164d
Merge branch 'master' into feature/webpack3
rkostrzewski Jul 24, 2017
1d17a28
Merge master into feature/webpack3
reznord Aug 8, 2017
8bed060
Merge branch 'master' into feature/webpack3
reznord Aug 10, 2017
19cbb6a
Fix snapshot values in build.snapshot.js
reznord Aug 22, 2017
466441b
Merge master
reznord Aug 22, 2017
a63775e
Fix merge conflicts & merge master
reznord Aug 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,6 @@
"uuid": "^3.0.1"
},
"dependencies": {
"@webpack-blocks/css-modules": "^0.4.0",
"@webpack-blocks/dev-server2": "^0.4.0",
"@webpack-blocks/extract-text2": "^0.4.0",
"@webpack-blocks/postcss": "^0.4.3",
"@webpack-blocks/webpack2": "^0.4.0",
"autoprefixer": "^7.1.0",
"babel-loader": "^7.0.0",
"babel-plugin-jsx-pragmatic": "^1.0.2",
Expand All @@ -113,11 +108,13 @@
"babel-register": "^6.24.1",
"copy-webpack-plugin": "^4.0.1",
"cross-spawn-promise": "^0.10.1",
"css-loader": "^0.28.4",
"css-modules-require-hook": "^4.0.6",
"devcert-san": "^0.3.3",
"ejs-loader": "^0.3.0",
"es6-promisify": "^5.0.0",
"file-loader": "^0.11.1",
"extract-text-webpack-plugin": "^3.0.0",
"file-loader": "^0.11.2",
"fs.promised": "^3.0.0",
"get-port": "^3.1.0",
"glob": "^7.1.2",
Expand All @@ -135,7 +132,8 @@
"offline-plugin": "^4.6.2",
"ora": "^1.2.0",
"persist-path": "^1.0.1",
"postcss-less": "^0.16.1",
"postcss-less": "^1.0.2",
"postcss-loader": "^2.0.6",
"preact": "^8.1.0",
"preact-compat": "^3.14.3",
"preact-render-to-string": "^3.6.0",
Expand All @@ -150,13 +148,15 @@
"simplehttp2server": "^2.0.0",
"source-map": "^0.5.6",
"stack-trace": "0.0.10",
"style-loader": "^0.18.2",
"sw-precache-webpack-plugin": "^0.11.2",
"tmp": "0.0.31",
"unfetch": "^3.0.0",
"url-loader": "^0.5.8",
"webpack": "^2.3.3",
"url-loader": "^0.5.9",
"webpack": "^3.3.0",
Copy link

@bwhitty bwhitty Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd definitely recommend using something higher than 3.3.0 if you're going to use ModuleConcatenationPlugin. I had to back out the use of the plugin in an internal app using 3.3.0 due to naming collisions and other strange demons. Check out the release notes of every release since 3.3.0 and you'll see module concat bugfixes. 👍 https://github.com/webpack/webpack/releases

Copy link
Collaborator

@thangngoc89 thangngoc89 Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwhitty Don't worry about that, semver will take care of it

"webpack-chunk-hash": "^0.4.0",
"webpack-dev-server": "^2.4.5",
"webpack-dev-server": "^2.6.1",
"webpack-merge": "^4.1.0",
"webpack-plugin-replace": "^1.1.1",
"which": "^1.2.14",
"yargs": "^8.0.1"
Expand Down
1 change: 0 additions & 1 deletion src/lib/webpack/run-webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export default async (watch=false, env, onprogress) => {
const devBuild = async (env, onprogress) => {
let config = clientConfig(env);
await transformConfig(env, config);

let userPort = parseInt(process.env.PORT || config.devServer.port, 10) || 8080;
let port = await getPort(userPort);

Expand Down
4 changes: 1 addition & 3 deletions src/lib/webpack/transform-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import path from 'path';
import fs from 'fs.promised';
import {
webpack,
} from '@webpack-blocks/webpack2';
import webpack from 'webpack';

export default async function (env, config, ssr = false) {
let transformerPath = path.resolve(env.cwd, env.config || './preact.config.js');
Expand Down
Loading