Skip to content

fix: Bug where port is reassigned after given to devServer #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForsakenHarmony merged 4 commits into from
Mar 6, 2021
Merged

fix: Bug where port is reassigned after given to devServer #1530

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa05ff7
fix: Bug where port is reassigned after given to devServer
rschristian Feb 5, 2021
a040969
docs: Adding changeset
rschristian Feb 5, 2021
a1f9c20
Merge branch 'master' into fix/portReassignment
rschristian Feb 7, 2021
5b5a8fa
Merge branch 'master' into fix/portReassignment
ForsakenHarmony Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-fans-sin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-cli': patch
---

Fixes bug causing wrong port to be given to Webpack config
7 changes: 4 additions & 3 deletions packages/cli/lib/lib/webpack/run-webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ const transformConfig = require('./transform-config');
const { error, isDir, warn } = require('../../util');

async function devBuild(env) {
let userPort = parseInt(process.env.PORT || env.port, 10) || 8080;
env.port = await getPort({ port: userPort });

let config = await clientConfig(env);

await transformConfig(env, config);

let userPort =
parseInt(process.env.PORT || config.devServer.port, 10) || 8080;
let port = await getPort({ port: userPort });
let port = config.devServer.port;

let compiler = webpack(config);
return new Promise((res, rej) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/lib/lib/webpack/webpack-client-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ function isDev(config) {
publicPath: '/',
contentBase: src,
https: config.https,
port: process.env.PORT || config.port || 8080,
port: config.port,
host: process.env.HOST || config.host || '0.0.0.0',
disableHostCheck: true,
historyApiFallback: true,
Expand Down