Chore/remove safari nomodule polyfill #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1db8f5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
developit
reviewed
May 30, 2021
rschristian
force-pushed
the
chore/remove-safari-nomodule-polyfill
branch
from
c370434 to
65a52f0
Compare
rschristian
force-pushed
the
chore/remove-safari-nomodule-polyfill
branch
from
65a52f0 to
5f6675f
Compare
developit
approved these changes
Jun 9, 2021
Member
developit
left a comment
developit
left a comment
There was a problem hiding this comment.
I think the time has come to remove this hack.
ForsakenHarmony
approved these changes
Sep 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Chore, removing unnecessary code
Did you add tests for your changes?
No
Summary
Was reminded of Safari's
nomodulepolyfill that we have. Pretty unnecessary these days, CanIUse lists 0.18% globally still affected which I think is fine to remove automatic support for.Users certainly could add the polyfill back in if they need it.
Does this PR introduce a breaking change?
No