fix: Ensuring the sw flag is a boolean in watch mode #1595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 05da988 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
fix/sw-watch
branch
from
24a6147 to
e2478e3
Compare
developit
approved these changes
Sep 15, 2021
ForsakenHarmony
approved these changes
Sep 30, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
**What kind of change does this PR introduce?** Bugfix **Did you add tests for your changes?** No **Summary** Fixes #1594 `preact watch --sw false` passed the value through as a string, rather than coercing to a boolean, which was an oversight. **Does this PR introduce a breaking change?** No
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Merged
This was referenced Oct 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
No
Summary
Fixes #1594
preact watch --sw falsepassed the value through as a string, rather than coercing to a boolean, which was an oversight.Does this PR introduce a breaking change?
No