Skip to content

Fix/sw watch coercion #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ForsakenHarmony merged 2 commits into from
Oct 12, 2021
Merged

Fix/sw watch coercion #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa9c781
fix: Don't coerce `undefined` sw flag to bool in dev
rschristian Oct 8, 2021
1c94e40
docs: Adding changeset
rschristian Oct 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lucky-hairs-lie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'preact-cli': patch
---

Reverts automatic conversion of `--sw` flag in dev to a boolean, which stopped the debug service worker from attaching.
4 changes: 3 additions & 1 deletion packages/cli/lib/commands/watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,9 @@ async function command(src, argv) {
}
argv.src = src || argv.src;
argv.production = false;
argv.sw = toBool(argv.sw);
if (argv.sw) {
argv.sw = toBool(argv.sw);
}

if (argv.https || process.env.HTTPS) {
let { key, cert, cacert } = argv;
Expand Down