Fix/port config precedence #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b6a1ee7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
force-pushed
the
fix/port-config-precedence
branch
from
5d978ec to
55160ee
Compare
ForsakenHarmony
approved these changes
Nov 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor to config precedence
Did you add tests for your changes?
Yes
Summary
Closes #1596
Determining the port is a tad different now:
--port->$PORT->8080-><random>Far left is preferred, far right is the fall back.
The other change is that if a user explicitly selects a port with
-p/--portthat is already taken, we throw an error and exit. That scenario is almost certainly a mistake, either in something running on a port it shouldn't or the wrong port passed to preact-cli. We will continue to fall back to random if$PORTis already set and already in use, with the idea being that it's probably another service setting and using that value.I believe this makes a bit more sense, though could just be my opinion. Let me know!
Does this PR introduce a breaking change?
No