Skip to content

Conversation

@rschristian
Copy link
Member

@rschristian rschristian commented Nov 13, 2021

What kind of change does this PR introduce?

Chore

Did you add tests for your changes?

N/A

Summary

  • ReadMe
    • Corrected required Node version in the ReadMe
    • Removed the deployment section as it hasn't been valid or useful for a while
    • Edited the --refresh flag to match the CLI description
    • Added in missing table of contents entries for env vars & route-based code splitting
  • Updated yarn.lock as it had some outdated items that we no longer used
  • Updated browserslist
  • Cleared out a couple TODOs that have sat untouched for years and would never get done.
  • Removes setHtmlTemplate helper
    • This has been non-functional for a fairly long time, is redundant, and no one has seemed to notice, so a silent removal shouldn't be problematic?

Note: Two tests should be failing at the moment, due to the .babelrc sat in the default template. I've opened a PR to remove it. The tests here should fail until that's gone. Merged, all good now

Does this PR introduce a breaking change?

N/A

@rschristian rschristian requested a review from a team as a code owner November 13, 2021 05:44
@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2021

🦋 Changeset detected

Latest commit: 5a0448f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ForsakenHarmony
Copy link
Member

should this have a changeset?

@rschristian
Copy link
Member Author

Yes, yes it should. Sorry about that.

@ForsakenHarmony ForsakenHarmony merged commit 3994a23 into master Nov 17, 2021
@ForsakenHarmony ForsakenHarmony deleted the chore/misc-cleaning branch November 17, 2021 17:42
@preact-bot preact-bot mentioned this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants