Feat/config types #1624
Feat/config types #1624
Conversation
🦋 Changeset detectedLatest commit: 0b9ee56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| export type Env = { | ||
| src: string; | ||
| dest: string; | ||
| esm: boolean; | ||
| sw: boolean; | ||
| dev: boolean; | ||
| production: boolean; | ||
| isProd: boolean; | ||
| ssr: boolean; | ||
| prerender: boolean; | ||
| [key: string]: any; | ||
| }; |
There was a problem hiding this comment.
Tried to cover the commonly used ones that I've seen. Did I miss any that should be added?
rschristian
force-pushed
the
feat/config-types
branch
from
4e767d7 to
e768580
Compare
rschristian
force-pushed
the
feat/config-types
branch
2 times, most recently
from
1492727 to
fe2603b
Compare
| @@ -1,154 +0,0 @@ | |||
| ### Table of Contents | |||
There was a problem hiding this comment.
(Repeating the comment from above as it seems to have been read over)
I think it would be better to move this content into the wiki to keep everything together a bit more. Currently you have to switch between this doc and the wiki for some config information which is a bit awkward in my experience.
Certainly interested in thoughts, or maybe we should move the common config recipes into a doc instead? Not sure, just feels a bit disconnected at the moment.
What kind of change does this PR introduce?
feature (types)
Did you add tests for your changes?
N/A
Summary
Provides types for import that can help users with their config files. While this won't provide types for the entire default config, it does help correct a number of mistakes and/or typos.
Side note: I'm partial to moving the
docs/webpack-helpers.mdinto the wiki, just to keep all that stuff together. Thoughts?Does this PR introduce a breaking change?
No