fix: TS warnings/errors hidden by console clearing #1635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
N/A
Summary
Closes preactjs-templates/typescript#69
ForkTsCheckeris ran async, and this usually (nearly always in my tests) results in errors/warnings being output before our owndonehook. With the console clearing triggering in this hook, this meant errors/warnings from this plugin were hidden from users. They'd have to scroll (and know to scroll) in order to expose them often (again, we've set the reporting to async, so this output could come after, but it seems pretty rare w/ the TS template).By moving this to the
beforeCompilehook, we can ensure this output is not covered up.beforeCompileseemed like the best fit; it shows the initial webpack dev server info, progress plugin stuff, and even fixes the awkward issue of progress plugin and wds doubling up:before
after
Anything before
donewill work just fine though, as that's whenForkTsCheckeroutputs. Not sure if there's a more idiomatic place for this.Does this PR introduce a breaking change?
No